Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-07 Thread David Rientjes
On Sun, 4 Nov 2018, Yangtao Li wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to use > unlikely. > > Signed-off-by: Yangtao Li Acked-by: David Rientjes

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-07 Thread David Rientjes
On Sun, 4 Nov 2018, Yangtao Li wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to use > unlikely. > > Signed-off-by: Yangtao Li Acked-by: David Rientjes

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-06 Thread Vlastimil Babka
On 11/6/18 6:38 AM, Dmitry Vyukov wrote: > On Mon, Nov 5, 2018 at 11:18 AM, Vlastimil Babka wrote: >> +CC Dmitry >> >> On 11/4/18 1:50 PM, Yangtao Li wrote: >>> WARN_ON() already contains an unlikely(), so it's not necessary to use >>> unlikely. >>> >>> Signed-off-by: Yangtao Li >> >> Acked-by:

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-06 Thread Vlastimil Babka
On 11/6/18 6:38 AM, Dmitry Vyukov wrote: > On Mon, Nov 5, 2018 at 11:18 AM, Vlastimil Babka wrote: >> +CC Dmitry >> >> On 11/4/18 1:50 PM, Yangtao Li wrote: >>> WARN_ON() already contains an unlikely(), so it's not necessary to use >>> unlikely. >>> >>> Signed-off-by: Yangtao Li >> >> Acked-by:

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-05 Thread Dmitry Vyukov
On Mon, Nov 5, 2018 at 11:18 AM, Vlastimil Babka wrote: > +CC Dmitry > > On 11/4/18 1:50 PM, Yangtao Li wrote: >> WARN_ON() already contains an unlikely(), so it's not necessary to use >> unlikely. >> >> Signed-off-by: Yangtao Li > > Acked-by: Vlastimil Babka > > Maybe also change it back to

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-05 Thread Dmitry Vyukov
On Mon, Nov 5, 2018 at 11:18 AM, Vlastimil Babka wrote: > +CC Dmitry > > On 11/4/18 1:50 PM, Yangtao Li wrote: >> WARN_ON() already contains an unlikely(), so it's not necessary to use >> unlikely. >> >> Signed-off-by: Yangtao Li > > Acked-by: Vlastimil Babka > > Maybe also change it back to

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-05 Thread Vlastimil Babka
+CC Dmitry On 11/4/18 1:50 PM, Yangtao Li wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to use > unlikely. > > Signed-off-by: Yangtao Li Acked-by: Vlastimil Babka Maybe also change it back to WARN_ON_ONCE? I already considered it while reviewing Dmitry's patch and

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-05 Thread Vlastimil Babka
+CC Dmitry On 11/4/18 1:50 PM, Yangtao Li wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to use > unlikely. > > Signed-off-by: Yangtao Li Acked-by: Vlastimil Babka Maybe also change it back to WARN_ON_ONCE? I already considered it while reviewing Dmitry's patch and

[PATCH] mm, slab: remove unnecessary unlikely()

2018-11-04 Thread Yangtao Li
WARN_ON() already contains an unlikely(), so it's not necessary to use unlikely. Signed-off-by: Yangtao Li --- mm/slab_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 7eb8dc136c1c..4f54684f5435 100644 ---

[PATCH] mm, slab: remove unnecessary unlikely()

2018-11-04 Thread Yangtao Li
WARN_ON() already contains an unlikely(), so it's not necessary to use unlikely. Signed-off-by: Yangtao Li --- mm/slab_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 7eb8dc136c1c..4f54684f5435 100644 ---