Re: [PATCH] mm/THP: use hugepage_vma_check() in khugepaged_enter_vma_merge()

2018-05-22 Thread Song Liu
On May 22, 2018, at 5:13 AM, Michal Hocko wrote: > > [CC Kirill] > > On Mon 21-05-18 12:38:53, Song Liu wrote: >> khugepaged_enter_vma_merge() is using a different approach to check >> whether a vma is valid for khugepaged_enter(): >> >>if (!vma->anon_vma) >>/* >> *

Re: [PATCH] mm/THP: use hugepage_vma_check() in khugepaged_enter_vma_merge()

2018-05-22 Thread Michal Hocko
[CC Kirill] On Mon 21-05-18 12:38:53, Song Liu wrote: > khugepaged_enter_vma_merge() is using a different approach to check > whether a vma is valid for khugepaged_enter(): > > if (!vma->anon_vma) > /* > * Not yet faulted in so we will register later in the >

Re: [PATCH] mm/THP: use hugepage_vma_check() in khugepaged_enter_vma_merge()

2018-05-21 Thread David Rientjes
On Mon, 21 May 2018, Song Liu wrote: > khugepaged_enter_vma_merge() is using a different approach to check > whether a vma is valid for khugepaged_enter(): > > if (!vma->anon_vma) > /* > * Not yet faulted in so we will register later in the > * page fault

Re: [PATCH] mm/THP: use hugepage_vma_check() in khugepaged_enter_vma_merge()

2018-05-21 Thread Rik van Riel
On Mon, 2018-05-21 at 12:38 -0700, Song Liu wrote: > This patch fixes these problems by reusing hugepage_vma_check() in > khugepaged_enter_vma_merge(). Lets take a look at this in more detail. This effectively adds the following conditions to khugepaged_enter_vma_merge: - fail if MMF_DISABLE_THP

[PATCH] mm/THP: use hugepage_vma_check() in khugepaged_enter_vma_merge()

2018-05-21 Thread Song Liu
khugepaged_enter_vma_merge() is using a different approach to check whether a vma is valid for khugepaged_enter(): if (!vma->anon_vma) /* * Not yet faulted in so we will register later in the * page fault if needed. */ return 0;