Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Andrew Morton writes: > On Tue, 07 Apr 2015 16:27:44 -0700 Kevin Hilman wrote: > >> >> > It should all be there today? >> >> >> >> Nope. >> > >> > huh, I swear I did an mmotm yesterday. >> >> Well, based on the timestamp of the mmotm dir on ozlabs, it appears you >> did. That's why I was

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-07 Thread Andrew Morton
On Tue, 07 Apr 2015 16:27:44 -0700 Kevin Hilman wrote: > >> > It should all be there today? > >> > >> Nope. > > > > huh, I swear I did an mmotm yesterday. > > Well, based on the timestamp of the mmotm dir on ozlabs, it appears you > did. That's why I was confused why the gcc-473 patches

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Andrew Morton writes: > On Tue, 07 Apr 2015 15:41:32 -0700 Kevin Hilman wrote: > >> Andrew Morton writes: >> >> > On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman wrote: >> > >> >> > The diff below[2] on top of yours compiles fine here and at least covers >> >> > the compilers I *know* to

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-07 Thread Andrew Morton
On Tue, 07 Apr 2015 15:41:32 -0700 Kevin Hilman wrote: > Andrew Morton writes: > > > On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman wrote: > > > >> > The diff below[2] on top of yours compiles fine here and at least covers > >> > the compilers I *know* to trigger the ICE. > >> > >> I see my

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Andrew Morton writes: > On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman wrote: > >> > The diff below[2] on top of yours compiles fine here and at least covers >> > the compilers I *know* to trigger the ICE. >> >> I see my fix in your mmots since last Thurs (4/2), but it's not in >> mmotm (last

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-07 Thread Andrew Morton
On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman wrote: > > The diff below[2] on top of yours compiles fine here and at least covers > > the compilers I *know* to trigger the ICE. > > I see my fix in your mmots since last Thurs (4/2), but it's not in > mmotm (last updated today) so today's

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Hi Andrew, On Wed, Apr 1, 2015 at 2:54 PM, Kevin Hilman wrote: > Andrew Morton writes: > >> On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier wrote: >> >>> > -static int unmap_and_move(new_page_t get_new_page, free_page_t >>> > put_new_page, >>> > - unsigned long private,

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Hi Andrew, On Wed, Apr 1, 2015 at 2:54 PM, Kevin Hilman khil...@kernel.org wrote: Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier marc.zyng...@arm.com wrote: -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page, -

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-07 Thread Andrew Morton
On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman khil...@kernel.org wrote: The diff below[2] on top of yours compiles fine here and at least covers the compilers I *know* to trigger the ICE. I see my fix in your mmots since last Thurs (4/2), but it's not in mmotm (last updated today) so

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Andrew Morton a...@linux-foundation.org writes: On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman khil...@kernel.org wrote: The diff below[2] on top of yours compiles fine here and at least covers the compilers I *know* to trigger the ICE. I see my fix in your mmots since last Thurs (4/2),

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Andrew Morton a...@linux-foundation.org writes: On Tue, 07 Apr 2015 15:41:32 -0700 Kevin Hilman khil...@kernel.org wrote: Andrew Morton a...@linux-foundation.org writes: On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman khil...@kernel.org wrote: The diff below[2] on top of yours compiles

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-07 Thread Kevin Hilman
Andrew Morton a...@linux-foundation.org writes: On Tue, 07 Apr 2015 16:27:44 -0700 Kevin Hilman khil...@kernel.org wrote: It should all be there today? Nope. huh, I swear I did an mmotm yesterday. Well, based on the timestamp of the mmotm dir on ozlabs, it appears you did.

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-07 Thread Andrew Morton
On Tue, 07 Apr 2015 15:41:32 -0700 Kevin Hilman khil...@kernel.org wrote: Andrew Morton a...@linux-foundation.org writes: On Tue, 7 Apr 2015 10:57:52 -0700 Kevin Hilman khil...@kernel.org wrote: The diff below[2] on top of yours compiles fine here and at least covers the compilers I

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-07 Thread Andrew Morton
On Tue, 07 Apr 2015 16:27:44 -0700 Kevin Hilman khil...@kernel.org wrote: It should all be there today? Nope. huh, I swear I did an mmotm yesterday. Well, based on the timestamp of the mmotm dir on ozlabs, it appears you did. That's why I was confused why the gcc-473 patches

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-02 Thread Lina Iyer
On Thu, Apr 02 2015 at 15:12 -0600, Kevin Hilman wrote: On Thu, Apr 2, 2015 at 12:12 PM, Lina Iyer wrote: On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier wrote: > -static int unmap_and_move(new_page_t

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-02 Thread Kevin Hilman
On Thu, Apr 2, 2015 at 12:12 PM, Lina Iyer wrote: > On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: >> >> Andrew Morton writes: >> >>> On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier >>> wrote: >>> > -static int unmap_and_move(new_page_t get_new_page, free_page_t >

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-02 Thread Lina Iyer
On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier wrote: > -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page, > - unsigned long private, struct page *page, int force, > -

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-02 Thread Geert Uytterhoeven
Hi Russell, On Wed, Apr 1, 2015 at 11:59 PM, Russell King - ARM Linux wrote: > On Wed, Apr 01, 2015 at 02:54:59PM -0700, Kevin Hilman wrote: >> Your patch on top of Geert's still compiles fine for me with gcc-4.7.3. >> However, I'm not sure how specific we can be on the versions. >> >> /me goes

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Geert Uytterhoeven
Hi Russell, On Wed, Apr 1, 2015 at 11:59 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Apr 01, 2015 at 02:54:59PM -0700, Kevin Hilman wrote: Your patch on top of Geert's still compiles fine for me with gcc-4.7.3. However, I'm not sure how specific we can be on the

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Kevin Hilman
On Thu, Apr 2, 2015 at 12:12 PM, Lina Iyer lina.i...@linaro.org wrote: On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier marc.zyng...@arm.com wrote: -static int unmap_and_move(new_page_t

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Lina Iyer
On Thu, Apr 02 2015 at 15:12 -0600, Kevin Hilman wrote: On Thu, Apr 2, 2015 at 12:12 PM, Lina Iyer lina.i...@linaro.org wrote: On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-02 Thread Lina Iyer
On Wed, Apr 01 2015 at 15:57 -0600, Kevin Hilman wrote: Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier marc.zyng...@arm.com wrote: -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page, - unsigned long

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-01 Thread Russell King - ARM Linux
On Wed, Apr 01, 2015 at 02:54:59PM -0700, Kevin Hilman wrote: > Your patch on top of Geert's still compiles fine for me with gcc-4.7.3. > However, I'm not sure how specific we can be on the versions. > > /me goes to test a few more compilers... OK... > > ICE: 4.7.1, 4.7.3, 4.8.3 > OK: 4.6.3,

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-01 Thread Kevin Hilman
Andrew Morton writes: > On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier wrote: > >> > -static int unmap_and_move(new_page_t get_new_page, free_page_t >> > put_new_page, >> > - unsigned long private, struct page *page, int force, >> > - enum migrate_mode mode)

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-01 Thread Andrew Morton
On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier wrote: > > -static int unmap_and_move(new_page_t get_new_page, free_page_t > > put_new_page, > > - unsigned long private, struct page *page, int force, > > - enum migrate_mode mode) > > +static noinline int

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-01 Thread Kevin Hilman
ted to this ICE. > From 7ebe83316eaf1952e55a76754ce7a5832e461b8c Mon Sep 17 00:00:00 2001 > From: Geert Uytterhoeven > Date: Wed, 1 Apr 2015 11:22:51 +0200 > Subject: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in > gcc 4.7.3 > MIME-Version: 1.0 > Content-Type

Re: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3

2015-04-01 Thread Marc Zyngier
t any further than that yet. > > I installed gcc-arm-linux-gnueabi (4:4.7.2-1 from Ubuntu 14.04 LTS) and could > reproduce the ICE. I came up with the workaround below. > Does this work for you? > > From 7ebe83316eaf1952e55a76754ce7a5832e461b8c Mon Sep 17 00:00:00 2001 > Fro

[PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3 (was: Re: Possible regression in gcc 4.7.3 next-20150323 due to "ARM, arm64: kvm: get rid of the bounce page")

2015-04-01 Thread Geert Uytterhoeven
Does this work for you? >From 7ebe83316eaf1952e55a76754ce7a5832e461b8c Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven Date: Wed, 1 Apr 2015 11:22:51 +0200 Subject: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3 MIME-Version: 1.0 Content-Type: t

[PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3 (was: Re: Possible regression in gcc 4.7.3 next-20150323 due to ARM, arm64: kvm: get rid of the bounce page)

2015-04-01 Thread Geert Uytterhoeven
00:00:00 2001 From: Geert Uytterhoeven geert+rene...@glider.be Date: Wed, 1 Apr 2015 11:22:51 +0200 Subject: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With gcc version

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-01 Thread Marc Zyngier
7ebe83316eaf1952e55a76754ce7a5832e461b8c Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven geert+rene...@glider.be Date: Wed, 1 Apr 2015 11:22:51 +0200 Subject: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-01 Thread Kevin Hilman
7ebe83316eaf1952e55a76754ce7a5832e461b8c Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven geert+rene...@glider.be Date: Wed, 1 Apr 2015 11:22:51 +0200 Subject: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-01 Thread Andrew Morton
On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier marc.zyng...@arm.com wrote: -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page, - unsigned long private, struct page *page, int force, - enum migrate_mode mode) +static

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-01 Thread Kevin Hilman
Andrew Morton a...@linux-foundation.org writes: On Wed, 01 Apr 2015 10:47:49 +0100 Marc Zyngier marc.zyng...@arm.com wrote: -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page, - unsigned long private, struct page *page, int force, -

Re: [PATCH] mm/migrate: Mark unmap_and_move() noinline to avoid ICE in gcc 4.7.3

2015-04-01 Thread Russell King - ARM Linux
On Wed, Apr 01, 2015 at 02:54:59PM -0700, Kevin Hilman wrote: Your patch on top of Geert's still compiles fine for me with gcc-4.7.3. However, I'm not sure how specific we can be on the versions. /me goes to test a few more compilers... OK... ICE: 4.7.1, 4.7.3, 4.8.3 OK: 4.6.3, 4.9.2,