Re: [PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier()

2018-11-06 Thread Sean Christopherson
On Mon, 2018-11-05 at 13:14 -0800, Matthew Wilcox wrote: > On Mon, Nov 05, 2018 at 12:18:33PM -0800, Andrew Morton wrote: > > > > > > > > +++ b/mm/mmu_notifier.c > > But as it has no callers, why retain it? > ... and this patch missed the declaration of mmu_notifier_synchronize > in include/linux

Re: [PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier()

2018-11-06 Thread Michal Hocko
On Mon 05-11-18 12:18:33, Andrew Morton wrote: > On Mon, 5 Nov 2018 11:29:55 -0800 Sean Christopherson > wrote: [...] > > -EXPORT_SYMBOL_GPL(mmu_notifier_synchronize); > > +EXPORT_SYMBOL_GPL(mmu_notifier_barrier); > > > > /* > > * This function can't run concurrently against mmu_notifier_re

Re: [PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier()

2018-11-05 Thread Matthew Wilcox
On Mon, Nov 05, 2018 at 12:18:33PM -0800, Andrew Morton wrote: > > +++ b/mm/mmu_notifier.c > > But as it has no callers, why retain it? ... and this patch missed the declaration of mmu_notifier_synchronize in include/linux/mmu_notifier.h (whether we delete it or rename it, that mention of it need

Re: [PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier()

2018-11-05 Thread Sean Christopherson
On Mon, Nov 05, 2018 at 12:18:33PM -0800, Andrew Morton wrote: > On Mon, 5 Nov 2018 11:29:55 -0800 Sean Christopherson > wrote: > > > ...and update its comment to explicitly reference its association with > > mmu_notifier_call_srcu(). > > > > Contrary to its name, mmu_notifier_synchronize() do

Re: [PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier()

2018-11-05 Thread Andrew Morton
On Mon, 5 Nov 2018 11:29:55 -0800 Sean Christopherson wrote: > ...and update its comment to explicitly reference its association with > mmu_notifier_call_srcu(). > > Contrary to its name, mmu_notifier_synchronize() does not synchronize > the notifier's SRCU instance, but rather waits for RCU c

[PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier()

2018-11-05 Thread Sean Christopherson
...and update its comment to explicitly reference its association with mmu_notifier_call_srcu(). Contrary to its name, mmu_notifier_synchronize() does not synchronize the notifier's SRCU instance, but rather waits for RCU callbacks to finished, i.e. it invokes rcu_barrier(). The RCU documentation