[PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry() v2

2018-10-12 Thread jglisse
From: Jérôme Glisse Inside set_pmd_migration_entry() we are holding page table locks and thus we can not sleep so we can not call invalidate_range_start/end() So remove call to mmu_notifier_invalidate_range_start/end() because they are call inside the function calling set_pmd_migration_entry()

[PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry() v2

2018-10-12 Thread jglisse
From: Jérôme Glisse Inside set_pmd_migration_entry() we are holding page table locks and thus we can not sleep so we can not call invalidate_range_start/end() So remove call to mmu_notifier_invalidate_range_start/end() because they are call inside the function calling set_pmd_migration_entry()

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Andrea Arcangeli
On Fri, Oct 12, 2018 at 01:35:19PM -0400, Jerome Glisse wrote: > On Fri, Oct 12, 2018 at 01:24:22PM -0400, Andrea Arcangeli wrote: > > Hello, > > > > On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > > > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > > > > > From: Jérôme

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Andrea Arcangeli
On Fri, Oct 12, 2018 at 01:35:19PM -0400, Jerome Glisse wrote: > On Fri, Oct 12, 2018 at 01:24:22PM -0400, Andrea Arcangeli wrote: > > Hello, > > > > On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > > > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > > > > > From: Jérôme

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Jerome Glisse
On Fri, Oct 12, 2018 at 01:24:22PM -0400, Andrea Arcangeli wrote: > Hello, > > On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > > > From: Jérôme Glisse > > > > > > Inside set_pmd_migration_entry() we are holding page table

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Jerome Glisse
On Fri, Oct 12, 2018 at 01:24:22PM -0400, Andrea Arcangeli wrote: > Hello, > > On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > > > From: Jérôme Glisse > > > > > > Inside set_pmd_migration_entry() we are holding page table

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Andrea Arcangeli
Hello, On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > Inside set_pmd_migration_entry() we are holding page table locks and > > thus we can not sleep so we can not call invalidate_range_start/end() >

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Andrea Arcangeli
Hello, On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > Inside set_pmd_migration_entry() we are holding page table locks and > > thus we can not sleep so we can not call invalidate_range_start/end() >

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Jerome Glisse
On Fri, Oct 12, 2018 at 06:55:48PM +0200, Michal Hocko wrote: > On Fri 12-10-18 12:09:53, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > Inside set_pmd_migration_entry() we are holding page table locks and > > thus we can not sleep so we can not call invalidate_range_start/end() > >

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Jerome Glisse
On Fri, Oct 12, 2018 at 06:55:48PM +0200, Michal Hocko wrote: > On Fri 12-10-18 12:09:53, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > Inside set_pmd_migration_entry() we are holding page table locks and > > thus we can not sleep so we can not call invalidate_range_start/end() > >

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Michal Hocko
On Fri 12-10-18 12:09:53, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Inside set_pmd_migration_entry() we are holding page table locks and > thus we can not sleep so we can not call invalidate_range_start/end() > > So remove call to mmu_notifier_invalidate_range_start/end() and add >

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Michal Hocko
On Fri 12-10-18 12:09:53, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Inside set_pmd_migration_entry() we are holding page table locks and > thus we can not sleep so we can not call invalidate_range_start/end() > > So remove call to mmu_notifier_invalidate_range_start/end() and add >

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Zi Yan
On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Inside set_pmd_migration_entry() we are holding page table locks and > thus we can not sleep so we can not call invalidate_range_start/end() > > So remove call to mmu_notifier_invalidate_range_start/end() and add >

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Zi Yan
On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Inside set_pmd_migration_entry() we are holding page table locks and > thus we can not sleep so we can not call invalidate_range_start/end() > > So remove call to mmu_notifier_invalidate_range_start/end() and add >

[PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread jglisse
From: Jérôme Glisse Inside set_pmd_migration_entry() we are holding page table locks and thus we can not sleep so we can not call invalidate_range_start/end() So remove call to mmu_notifier_invalidate_range_start/end() and add call to mmu_notifier_invalidate_range(). Note that we are already

[PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread jglisse
From: Jérôme Glisse Inside set_pmd_migration_entry() we are holding page table locks and thus we can not sleep so we can not call invalidate_range_start/end() So remove call to mmu_notifier_invalidate_range_start/end() and add call to mmu_notifier_invalidate_range(). Note that we are already