Re: [PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-19 Thread Michal Hocko
On Mon 19-10-20 08:32:34, pi...@codeaurora.org wrote: [...] > b) This can be invoked from many places so we are adding the logging at > wrong layer? > If so, any other better places which can be explored? dup_mmap? > c) Adding logging at kernel layer is not the right approach to tackle this >

Re: [PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-18 Thread pintu
On 2020-10-05 12:50, Michal Hocko wrote: On Fri 02-10-20 21:53:37, pi...@codeaurora.org wrote: On 2020-10-02 17:47, Michal Hocko wrote: > > __vm_enough_memory: commitment overflow: ppid:150, pid:164, > > pages:62451 > > fork failed[count:0]: Cannot allocate memory > > While I understand that

Re: [PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-05 Thread Michal Hocko
On Fri 02-10-20 21:53:37, pi...@codeaurora.org wrote: > On 2020-10-02 17:47, Michal Hocko wrote: > > > > __vm_enough_memory: commitment overflow: ppid:150, pid:164, > > > pages:62451 > > > fork failed[count:0]: Cannot allocate memory > > > > While I understand that fork failing due to overrcomit

Re: [PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-02 Thread pintu
On 2020-10-02 17:47, Michal Hocko wrote: __vm_enough_memory: commitment overflow: ppid:150, pid:164, pages:62451 fork failed[count:0]: Cannot allocate memory While I understand that fork failing due to overrcomit heuristic is non intuitive and I have seen people scratching heads due to this

Re: [PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-02 Thread pintu
On 2020-10-02 17:41, Matthew Wilcox wrote: I don't think the __func__ is particularly useful information. I would also expect the name of the process to be more interesting than the PID. And why is the ppid useful? Dear Matthew, First, thank you so much for your review and comments. I

Re: [PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-02 Thread Michal Hocko
On Fri 02-10-20 17:27:41, Pintu Kumar wrote: > The headless embedded devices often come with very limited amount > of RAM such as: 256MB or even lesser. > These types of system often rely on command line interface which can > execute system commands in the background using the fork/exec

Re: [PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-02 Thread Matthew Wilcox
On Fri, Oct 02, 2020 at 05:27:41PM +0530, Pintu Kumar wrote: > This is the output we can see on a 256MB system and with a simple malloc > and fork program. > > [root@ ~]# cat /proc/meminfo > MemTotal: 249520 kB ==> 243MB > MemFree: 179100 kB > > PPID PID USERRSS

[PATCH] mm/util.c: Add error logs for commitment overflow

2020-10-02 Thread Pintu Kumar
The headless embedded devices often come with very limited amount of RAM such as: 256MB or even lesser. These types of system often rely on command line interface which can execute system commands in the background using the fork/exec combination. There could be even many child tasks invoked