Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-14 Thread Minchan Kim
On Tue, Jan 14, 2014 at 02:15:44PM +0800, Weijie Yang wrote: > On Tue, Jan 14, 2014 at 1:42 PM, Bob Liu wrote: > > > > On 01/14/2014 01:05 PM, Minchan Kim wrote: > >> On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: > >>> Hello Bob, > >>> > >>> On Tue, Jan 14, 2014 at 09:19:23AM

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-14 Thread Minchan Kim
On Tue, Jan 14, 2014 at 02:15:44PM +0800, Weijie Yang wrote: On Tue, Jan 14, 2014 at 1:42 PM, Bob Liu bob@oracle.com wrote: On 01/14/2014 01:05 PM, Minchan Kim wrote: On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800,

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
Hello, Kim 2014/1/14 Minchan Kim : > Hello Bob, > > On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: >> >> On 01/14/2014 07:35 AM, Minchan Kim wrote: >> > Hello, >> > >> > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: >> >> zswap can support multiple swapfiles. So we need to

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
2014/1/14 Bob Liu : > > On 01/14/2014 01:05 PM, Minchan Kim wrote: >> On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: >>> Hello Bob, >>> >>> On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: > Hello, > > On Sat,

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Weijie Yang
On Tue, Jan 14, 2014 at 1:42 PM, Bob Liu wrote: > > On 01/14/2014 01:05 PM, Minchan Kim wrote: >> On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: >>> Hello Bob, >>> >>> On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: >

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Bob Liu
On 01/14/2014 01:05 PM, Minchan Kim wrote: > On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: >> Hello Bob, >> >> On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: >>> >>> On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800,

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: > Hello Bob, > > On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: > > > > On 01/14/2014 07:35 AM, Minchan Kim wrote: > > > Hello, > > > > > > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: > > >> zswap can support

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: > > On 01/14/2014 07:35 AM, Minchan Kim wrote: > > Hello, > > > > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: > >> zswap can support multiple swapfiles. So we need to check > >> all zbud pool pages in zswap. > > >

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Bob Liu
On 01/14/2014 07:35 AM, Minchan Kim wrote: > Hello, > > On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: >> zswap can support multiple swapfiles. So we need to check >> all zbud pool pages in zswap. > > True but this patch is rather costly that we should iterate >

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: > zswap can support multiple swapfiles. So we need to check > all zbud pool pages in zswap. True but this patch is rather costly that we should iterate zswap_tree[MAX_SWAPFILES] to check it. SIGH. How about defining zswap_tress as

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. True but this patch is rather costly that we should iterate zswap_tree[MAX_SWAPFILES] to check it. SIGH. How about defining zswap_tress as

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Bob Liu
On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. True but this patch is rather costly that we should iterate zswap_tree[MAX_SWAPFILES] to

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. True but this

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Minchan Kim
On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Bob Liu
On 01/14/2014 01:05 PM, Minchan Kim wrote: On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: zswap

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Weijie Yang
On Tue, Jan 14, 2014 at 1:42 PM, Bob Liu bob@oracle.com wrote: On 01/14/2014 01:05 PM, Minchan Kim wrote: On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello,

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
2014/1/14 Bob Liu bob@oracle.com: On 01/14/2014 01:05 PM, Minchan Kim wrote: On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote: Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at

Re: [PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-13 Thread Cai Liu
Hello, Kim 2014/1/14 Minchan Kim minc...@kernel.org: Hello Bob, On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote: On 01/14/2014 07:35 AM, Minchan Kim wrote: Hello, On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote: zswap can support multiple swapfiles. So we need to

[PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-10 Thread Cai Liu
zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. Signed-off-by: Cai Liu --- mm/zswap.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index d93afa6..2438344 100644 --- a/mm/zswap.c +++

[PATCH] mm/zswap: Check all pool pages instead of one pool pages

2014-01-10 Thread Cai Liu
zswap can support multiple swapfiles. So we need to check all zbud pool pages in zswap. Signed-off-by: Cai Liu cai@samsung.com --- mm/zswap.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index d93afa6..2438344 100644 ---