[patch] mm: break circular include from linux/mmzone.h fix fix fix fix

2013-02-06 Thread David Rientjes
kernel/jump_label.c: In function ‘jump_label_module_notify’: kernel/jump_label.c:393:2: error: implicit declaration of function ‘notifier_from_errno’ [-Werror=implicit-function-declaration] kernel/jump_label.c: At top level: kernel/jump_label.c:396:8: error: variable ‘jump_label_module_nb’ has in

Re: [PATCH] mm: break circular include from linux/mmzone.h

2013-02-05 Thread Andrew Morton
On Tue, 05 Feb 2013 13:56:36 +0800 li guang wrote: > ___ 2013-02-04__ 21:20 -0800___David Rientjes_ > > On Tue, 5 Feb 2013, liguang wrote: > > > > > linux/mmzone.h included linux/memory_hotplug.h, > > > and linux/memory_hotplug.h also included > > > linux/mmzone.h, so there's a bad c

Re: [PATCH] mm: break circular include from linux/mmzone.h

2013-02-04 Thread li guang
在 2013-02-04一的 21:20 -0800，David Rientjes写道： > On Tue, 5 Feb 2013, liguang wrote: > > > linux/mmzone.h included linux/memory_hotplug.h, > > and linux/memory_hotplug.h also included > > linux/mmzone.h, so there's a bad cirlular. > > > > And both of these are protected by _LINUX_MMZONE_H and > __

Re: [PATCH] mm: break circular include from linux/mmzone.h

2013-02-04 Thread David Rientjes
On Tue, 5 Feb 2013, liguang wrote: > linux/mmzone.h included linux/memory_hotplug.h, > and linux/memory_hotplug.h also included > linux/mmzone.h, so there's a bad cirlular. > And both of these are protected by _LINUX_MMZONE_H and __LINUX_MEMORY_HOTPLUG_H, respectively, so what's the problem? --

[PATCH] mm: break circular include from linux/mmzone.h

2013-02-04 Thread liguang
linux/mmzone.h included linux/memory_hotplug.h, and linux/memory_hotplug.h also included linux/mmzone.h, so there's a bad cirlular. Signed-off-by: liguang --- drivers/hwmon/coretemp.c|2 ++ drivers/hwmon/via-cputemp.c |2 ++ include/linux/mmzone.h |1 - kernel/cpu.c