Re: [PATCH] mm: expland documentation over __read_mostly

2020-05-06 Thread Matthew Wilcox
On Wed, May 06, 2020 at 11:13:53PM +, Luis Chamberlain wrote: > + * execute a critial path. We should be mindful and selective of its use. "critical"

Re: [PATCH] mm: expland documentation over __read_mostly

2020-05-06 Thread Rafael Aquini
On Wed, May 06, 2020 at 11:13:53PM +, Luis Chamberlain wrote: > __read_mostly can easily be misused by folks, its not meant for > just read-only data. There are performance reasons for using it, but > we also don't provide any guidance about its use. Provide a bit more > guidance over it use.

[PATCH] mm: expland documentation over __read_mostly

2020-05-06 Thread Luis Chamberlain
__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Acked-by: Christoph Lameter Signed-off-by: Luis Chamberlain --- I sent

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-08 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 08:39:30AM -0700, Randy Dunlap wrote: > On 05/08/2018 04:23 AM, Matthew Wilcox wrote: > > On Tue, May 08, 2018 at 09:28:14AM +0100, David Howells wrote: > >> Randy Dunlap wrote: > >> > + * execute a critial path. We should be mindful and selective if its > use. >

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-08 Thread Randy Dunlap
On 05/08/2018 04:23 AM, Matthew Wilcox wrote: > On Tue, May 08, 2018 at 09:28:14AM +0100, David Howells wrote: >> Randy Dunlap wrote: >> + * execute a critial path. We should be mindful and selective if its use. >>> >>> of its u

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-08 Thread Christopher Lameter
On Mon, 7 May 2018, Luis R. Rodriguez wrote: > __read_mostly can easily be misused by folks, its not meant for > just read-only data. There are performance reasons for using it, but > we also don't provide any guidance about its use. Provide a bit more > guidance over it use. Acked-by: Christoph

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-08 Thread Matthew Wilcox
On Tue, May 08, 2018 at 09:28:14AM +0100, David Howells wrote: > Randy Dunlap wrote: > > > > + * execute a critial path. We should be mindful and selective if its use. > > > > of its use. > >

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-08 Thread David Howells
Randy Dunlap wrote: > > + * execute a critial path. We should be mindful and selective if its use. > > of its use. in its use. David

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-07 Thread Joel Fernandes
On May 7, 2018 4:15:06 PM PDT, "Luis R. Rodriguez" wrote: >__read_mostly can easily be misused by folks, its not meant for >just read-only data. There are performance reasons for using it, but >we also don't provide any guidance about its use. Provide a bit more >guidance over it use. > >Signed-

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-07 Thread Randy Dunlap
On 05/07/2018 04:15 PM, Luis R. Rodriguez wrote: > __read_mostly can easily be misused by folks, its not meant for > just read-only data. There are performance reasons for using it, but > we also don't provide any guidance about its use. Provide a bit more > guidance over it use. > > Signed-off-by

[PATCH] mm: expland documentation over __read_mostly

2018-05-07 Thread Luis R. Rodriguez
__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Signed-off-by: Luis R. Rodriguez --- include/linux/cache.h | 10