Re: [PATCH] mm: fix LRU balancing effect of new transparent huge pages

2020-05-11 Thread Shakeel Butt
On Mon, May 11, 2020 at 2:58 PM Andrew Morton wrote: > > On Mon, 11 May 2020 14:38:23 -0700 Shakeel Butt wrote: > > > On Mon, May 11, 2020 at 2:11 PM Andrew Morton > > wrote: > > > > > > On Sat, 9 May 2020 07:19:46 -0700 Shakeel Butt > > > wrote: > > > > > > > Currently, THP are counted as

Re: [PATCH] mm: fix LRU balancing effect of new transparent huge pages

2020-05-11 Thread Andrew Morton
On Mon, 11 May 2020 14:38:23 -0700 Shakeel Butt wrote: > On Mon, May 11, 2020 at 2:11 PM Andrew Morton > wrote: > > > > On Sat, 9 May 2020 07:19:46 -0700 Shakeel Butt wrote: > > > > > Currently, THP are counted as single pages until they are split right > > > before being swapped out.

Re: [PATCH] mm: fix LRU balancing effect of new transparent huge pages

2020-05-11 Thread Shakeel Butt
On Mon, May 11, 2020 at 2:11 PM Andrew Morton wrote: > > On Sat, 9 May 2020 07:19:46 -0700 Shakeel Butt wrote: > > > Currently, THP are counted as single pages until they are split right > > before being swapped out. However, at that point the VM is already in > > the middle of reclaim, and

Re: [PATCH] mm: fix LRU balancing effect of new transparent huge pages

2020-05-11 Thread Andrew Morton
On Sat, 9 May 2020 07:19:46 -0700 Shakeel Butt wrote: > Currently, THP are counted as single pages until they are split right > before being swapped out. However, at that point the VM is already in > the middle of reclaim, and adjusting the LRU balance then is useless. > > Always account THP

[PATCH] mm: fix LRU balancing effect of new transparent huge pages

2020-05-09 Thread Shakeel Butt
From: Johannes Weiner Currently, THP are counted as single pages until they are split right before being swapped out. However, at that point the VM is already in the middle of reclaim, and adjusting the LRU balance then is useless. Always account THP by the number of basepages, and remove the