Re: [PATCH] mm: mmap: remove verify_mm_writelocked()

2018-11-14 Thread David Rientjes
On Thu, 8 Nov 2018, Yangtao Li wrote: > We should get rid of this function. It no longer serves its purpose.This > is a historical artifact from 2005 where do_brk was called outside of > the core mm.We do have a proper abstraction in vm_brk_flags and that one > does the locking properly.So there

Re: [PATCH] mm: mmap: remove verify_mm_writelocked()

2018-11-14 Thread David Rientjes
On Thu, 8 Nov 2018, Yangtao Li wrote: > We should get rid of this function. It no longer serves its purpose.This > is a historical artifact from 2005 where do_brk was called outside of > the core mm.We do have a proper abstraction in vm_brk_flags and that one > does the locking properly.So there

Re: [PATCH] mm: mmap: remove verify_mm_writelocked()

2018-11-08 Thread Michal Hocko
On Thu 08-11-18 12:48:56, Yangtao Li wrote: > We should get rid of this function. It no longer serves its purpose.This > is a historical artifact from 2005 where do_brk was called outside of > the core mm.We do have a proper abstraction in vm_brk_flags and that one > does the locking properly.So

Re: [PATCH] mm: mmap: remove verify_mm_writelocked()

2018-11-08 Thread Michal Hocko
On Thu 08-11-18 12:48:56, Yangtao Li wrote: > We should get rid of this function. It no longer serves its purpose.This > is a historical artifact from 2005 where do_brk was called outside of > the core mm.We do have a proper abstraction in vm_brk_flags and that one > does the locking properly.So

[PATCH] mm: mmap: remove verify_mm_writelocked()

2018-11-08 Thread Yangtao Li
We should get rid of this function. It no longer serves its purpose.This is a historical artifact from 2005 where do_brk was called outside of the core mm.We do have a proper abstraction in vm_brk_flags and that one does the locking properly.So there is no need to use this function.

[PATCH] mm: mmap: remove verify_mm_writelocked()

2018-11-08 Thread Yangtao Li
We should get rid of this function. It no longer serves its purpose.This is a historical artifact from 2005 where do_brk was called outside of the core mm.We do have a proper abstraction in vm_brk_flags and that one does the locking properly.So there is no need to use this function.