Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-14 Thread Nicolas Pitre
On Sun, 12 Jan 2014, Russell King - ARM Linux wrote: > This patch makes their types match exactly with x86's definitions of > the same, which is the basic problem: on ARM, they all took "int" values > and returned "int"s, which leads to min() in nobootmem.c complaining. > >

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-14 Thread Nicolas Pitre
On Sun, 12 Jan 2014, Russell King - ARM Linux wrote: This patch makes their types match exactly with x86's definitions of the same, which is the basic problem: on ARM, they all took int values and returned ints, which leads to min() in nobootmem.c complaining. arch/arm/include/asm/bitops.h

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Santosh Shilimkar
On Monday 13 January 2014 06:33 PM, Russell King - ARM Linux wrote: > On Mon, Jan 13, 2014 at 03:31:28PM -0800, Andrew Morton wrote: >> On Mon, 13 Jan 2014 09:27:44 -0500 Santosh Shilimkar >> wrote: >> It seems to me to be absolutely silly to have code introduce a warning yet push the

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Russell King - ARM Linux
On Mon, Jan 13, 2014 at 03:31:28PM -0800, Andrew Morton wrote: > On Mon, 13 Jan 2014 09:27:44 -0500 Santosh Shilimkar > wrote: > > > > It seems to me to be absolutely silly to have code introduce a warning > > > yet push the fix for the warning via a completely different tree... > > > > > I

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Andrew Morton
On Mon, 13 Jan 2014 09:27:44 -0500 Santosh Shilimkar wrote: > > It seems to me to be absolutely silly to have code introduce a warning > > yet push the fix for the warning via a completely different tree... > > > I mixed it up. Sorry. Some how I thought there was some other build >

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Santosh Shilimkar
On Monday 13 January 2014 07:37 AM, Russell King - ARM Linux wrote: > On Sun, Jan 12, 2014 at 10:42:00AM -0500, Santosh Shilimkar wrote: >> On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: >>> On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: On Monday 09

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Russell King - ARM Linux
On Sun, Jan 12, 2014 at 10:42:00AM -0500, Santosh Shilimkar wrote: > On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: > > On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: > >> On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: > >>> The

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Russell King - ARM Linux
On Sun, Jan 12, 2014 at 10:42:00AM -0500, Santosh Shilimkar wrote: On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: The underlying

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Santosh Shilimkar
On Monday 13 January 2014 07:37 AM, Russell King - ARM Linux wrote: On Sun, Jan 12, 2014 at 10:42:00AM -0500, Santosh Shilimkar wrote: On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: On Monday 09 December

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Andrew Morton
On Mon, 13 Jan 2014 09:27:44 -0500 Santosh Shilimkar santosh.shilim...@ti.com wrote: It seems to me to be absolutely silly to have code introduce a warning yet push the fix for the warning via a completely different tree... I mixed it up. Sorry. Some how I thought there was some other

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Russell King - ARM Linux
On Mon, Jan 13, 2014 at 03:31:28PM -0800, Andrew Morton wrote: On Mon, 13 Jan 2014 09:27:44 -0500 Santosh Shilimkar santosh.shilim...@ti.com wrote: It seems to me to be absolutely silly to have code introduce a warning yet push the fix for the warning via a completely different tree...

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-13 Thread Santosh Shilimkar
On Monday 13 January 2014 06:33 PM, Russell King - ARM Linux wrote: On Mon, Jan 13, 2014 at 03:31:28PM -0800, Andrew Morton wrote: On Mon, 13 Jan 2014 09:27:44 -0500 Santosh Shilimkar santosh.shilim...@ti.com wrote: It seems to me to be absolutely silly to have code introduce a warning yet

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-12 Thread Santosh Shilimkar
On Sunday 12 January 2014 10:42 AM, Santosh Shilimkar wrote: > On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: >> On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: >>> On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: The underlying

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-12 Thread Santosh Shilimkar
On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: > On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: >> On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: >>> The underlying reason is that - as I've already explained - ARM's __ffs() >>> differs

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-12 Thread Russell King - ARM Linux
On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: > On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: > > The underlying reason is that - as I've already explained - ARM's __ffs() > > differs from other architectures in that it ends up being an int, whereas > >

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-12 Thread Russell King - ARM Linux
On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: The underlying reason is that - as I've already explained - ARM's __ffs() differs from other architectures in that it ends up being an int, whereas almost

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-12 Thread Santosh Shilimkar
On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: The underlying reason is that - as I've already explained - ARM's __ffs() differs from

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2014-01-12 Thread Santosh Shilimkar
On Sunday 12 January 2014 10:42 AM, Santosh Shilimkar wrote: On Sunday 12 January 2014 05:59 AM, Russell King - ARM Linux wrote: On Mon, Dec 09, 2013 at 08:02:30PM -0500, Santosh Shilimkar wrote: On Monday 09 December 2013 07:54 PM, Russell King - ARM Linux wrote: The underlying reason is that

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Santosh Shilimkar
;>>> >>> Damn.. Posted a wrong version of the patch ;-( >>> Here is the one with warning message included. >>> >>> >From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 >>> From: Santosh Shilimkar >>> Date: Sat, 23 Nov 2013 18:

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Russell King - ARM Linux
ed. > > > > >From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 > > From: Santosh Shilimkar > > Date: Sat, 23 Nov 2013 18:16:50 -0500 > > Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value > > > > Building ARM wit

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Andrew Morton
in_t > > > >Where is that below? :-) > > > Damn.. Posted a wrong version of the patch ;-( > Here is the one with warning message included. > > >From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 > From: Santosh Shilimkar > Date: S

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Santosh Shilimkar
1dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 >> From: Santosh Shilimkar >> Date: Sat, 23 Nov 2013 18:16:50 -0500 >> Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value >> >> Building ARM with NO_BOOTMEM generates below warn

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Santosh Shilimkar
-0500 Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value Building ARM with NO_BOOTMEM generates below warning. mm/nobootmem.c: In function ‘__free_pages_memory’: mm/nobootmem.c:88:11: warning: comparison of distinct pointer types lacks a cast Using min_t to find

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Andrew Morton
: nobootmem: avoid type warning about alignment value Building ARM with NO_BOOTMEM generates below warning. mm/nobootmem.c: In function _free_pages_memory___: mm/nobootmem.c:88:11: warning: comparison of distinct pointer types lacks a cast Using min_t to find the correct alignment avoids

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Russell King - ARM Linux
santosh.shilim...@ti.com Date: Sat, 23 Nov 2013 18:16:50 -0500 Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value Building ARM with NO_BOOTMEM generates below warning. mm/nobootmem.c: In function _free_pages_memory___: mm/nobootmem.c:88:11: warning: comparison

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-12-09 Thread Santosh Shilimkar
:00 2001 From: Santosh Shilimkar santosh.shilim...@ti.com Date: Sat, 23 Nov 2013 18:16:50 -0500 Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value Building ARM with NO_BOOTMEM generates below warning. mm/nobootmem.c: In function _free_pages_memory___: mm/nobootmem.c

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-25 Thread Tejun Heo
rning. Using min_t > > > >Where is that below? :-) > > > Damn.. Posted a wrong version of the patch ;-( > Here is the one with warning message included. > > From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 > From: Santosh Shilimkar > Date: Sat,

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-25 Thread Santosh Shilimkar
e patch ;-( Here is the one with warning message included. >From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Sat, 23 Nov 2013 18:16:50 -0500 Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value Building ARM with NO_BOOTME

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-25 Thread Santosh Shilimkar
message included. From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar santosh.shilim...@ti.com Date: Sat, 23 Nov 2013 18:16:50 -0500 Subject: [PATCH] mm: nobootmem: avoid type warning about alignment value Building ARM with NO_BOOTMEM generates below warning

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-25 Thread Tejun Heo
? :-) Damn.. Posted a wrong version of the patch ;-( Here is the one with warning message included. From 571dfdf4cf8ac7dfd50bd9b7519717c42824f1c3 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar santosh.shilim...@ti.com Date: Sat, 23 Nov 2013 18:16:50 -0500 Subject: [PATCH] mm: nobootmem: avoid type

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-24 Thread Sergei Shtylyov
Hello. On 24-11-2013 3:28, Santosh Shilimkar wrote: Building ARM with NO_BOOTMEM generates below warning. Using min_t Where is that below? :-) to find the correct alignment avoids the warning. Cc: Tejun Heo Cc: Andrew Morton Signed-off-by: Santosh Shilimkar WBR, Sergei -- To

Re: [PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-24 Thread Sergei Shtylyov
Hello. On 24-11-2013 3:28, Santosh Shilimkar wrote: Building ARM with NO_BOOTMEM generates below warning. Using min_t Where is that below? :-) to find the correct alignment avoids the warning. Cc: Tejun Heo t...@kernel.org Cc: Andrew Morton a...@linux-foundation.org Signed-off-by:

[PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-23 Thread Santosh Shilimkar
Building ARM with NO_BOOTMEM generates below warning. Using min_t to find the correct alignment avoids the warning. Cc: Tejun Heo Cc: Andrew Morton Signed-off-by: Santosh Shilimkar --- mm/nobootmem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/nobootmem.c

[PATCH] mm: nobootmem: avoid type warning about alignment value

2013-11-23 Thread Santosh Shilimkar
Building ARM with NO_BOOTMEM generates below warning. Using min_t to find the correct alignment avoids the warning. Cc: Tejun Heo t...@kernel.org Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- mm/nobootmem.c |2 +- 1 file changed, 1