Re: [PATCH] mm: pagewalk: prevent positive return value of walk_page_test() from being passed to callers (Re: [PATCH] mm: fix do_mbind return value)

2015-03-05 Thread David Rientjes
On Thu, 5 Mar 2015, Naoya Horiguchi wrote: walk_page_test() is purely pagewalk's internal stuff, and its positive return values are not intended to be passed to the callers of pagewalk. However, in the current code if the last vma in the do-while loop in walk_page_range() happens to return a

Re: [PATCH] mm: pagewalk: prevent positive return value of walk_page_test() from being passed to callers (Re: [PATCH] mm: fix do_mbind return value)

2015-03-05 Thread Naoya Horiguchi
From 107fa3fb256bddff40a882c90af717af9863aed7 Mon Sep 17 00:00:00 2001 From: Naoya Horiguchi n-horigu...@ah.jp.nec.com Date: Thu, 5 Mar 2015 16:37:37 +0900 Subject: [PATCH] mm: pagewalk: prevent positive return value of walk_page_test() from being passed to callers walk_page_test()

[PATCH] mm: pagewalk: prevent positive return value of walk_page_test() from being passed to callers (Re: [PATCH] mm: fix do_mbind return value)

2015-03-05 Thread Naoya Horiguchi
# CCed Andrew and linux-mm On Wed, Mar 04, 2015 at 10:53:27PM -0800, David Rientjes wrote: On Wed, 4 Mar 2015, Kazutomo Yoshii wrote: I noticed that numa_alloc_onnode() failed to allocate memory on a specified node in v4.0-rc1. I added a code to check the return value of

Re: [PATCH] mm: pagewalk: prevent positive return value of walk_page_test() from being passed to callers (Re: [PATCH] mm: fix do_mbind return value)

2015-03-05 Thread Naoya Horiguchi
On Thu, Mar 05, 2015 at 08:02:27AM +, Horiguchi Naoya(堀口 直也) wrote: ... --- From 107fa3fb256bddff40a882c90af717af9863aed7 Mon Sep 17 00:00:00 2001 From: Naoya Horiguchi n-horigu...@ah.jp.nec.com Date: Thu, 5 Mar 2015 16:37:37 +0900 Subject: [PATCH] mm: pagewalk: prevent positive return