Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread YingHang Zhu
Hi Fengguang, On Fri, Oct 26, 2012 at 4:02 PM, Fengguang Wu wrote: > On Fri, Oct 26, 2012 at 03:47:19PM +0800, Ni zhan Chen wrote: >> On 10/26/2012 03:36 PM, Fengguang Wu wrote: >> >On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: >> >>On 10/26/2012 03:09 PM, Fengguang Wu wrote: >>

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 04:02 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:47:19PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:36 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:47:19PM +0800, Ni zhan Chen wrote: > On 10/26/2012 03:36 PM, Fengguang Wu wrote: > >On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: > >>On 10/26/2012 03:09 PM, Fengguang Wu wrote: > >>>On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: > On

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 03:36 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: > On 10/26/2012 03:09 PM, Fengguang Wu wrote: > >On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: > >>On 10/26/2012 02:58 PM, Fengguang Wu wrote: > static void shrink_readahead_size_eio(struct file *filp, >

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void shrink_readahead_size_eio(struct file *filp, struct file_ra_state *ra) { -

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: > On 10/26/2012 02:58 PM, Fengguang Wu wrote: > >> static void shrink_readahead_size_eio(struct file *filp, > >> struct file_ra_state *ra) > >> { > >>- ra->ra_pages /= 4; > >>+

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void shrink_readahead_size_eio(struct file *filp, struct file_ra_state *ra) { - ra->ra_pages /= 4; + spin_lock(>f_lock); + filp->f_mode |= FMODE_RANDOM; + spin_unlock(>f_lock);

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
> static void shrink_readahead_size_eio(struct file *filp, > struct file_ra_state *ra) > { > - ra->ra_pages /= 4; > + spin_lock(>f_lock); > + filp->f_mode |= FMODE_RANDOM; > + spin_unlock(>f_lock); > > As the example in comment

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
static void shrink_readahead_size_eio(struct file *filp, struct file_ra_state *ra) { - ra-ra_pages /= 4; + spin_lock(filp-f_lock); + filp-f_mode |= FMODE_RANDOM; + spin_unlock(filp-f_lock); As the example in comment above

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void shrink_readahead_size_eio(struct file *filp, struct file_ra_state *ra) { - ra-ra_pages /= 4; + spin_lock(filp-f_lock); + filp-f_mode |= FMODE_RANDOM; +

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void shrink_readahead_size_eio(struct file *filp, struct file_ra_state *ra) { - ra-ra_pages /= 4; +

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void shrink_readahead_size_eio(struct file *filp, struct file_ra_state *ra) { -

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void shrink_readahead_size_eio(struct file *filp,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 03:36 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: On 10/26/2012 02:58 PM, Fengguang Wu wrote: static void

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:47:19PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:36 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: On 10/26/2012 02:58

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Ni zhan Chen
On 10/26/2012 04:02 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:47:19PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:36 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:09 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:03:12PM

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread YingHang Zhu
Hi Fengguang, On Fri, Oct 26, 2012 at 4:02 PM, Fengguang Wu fengguang...@intel.com wrote: On Fri, Oct 26, 2012 at 03:47:19PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:36 PM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: On 10/26/2012 03:09 PM, Fengguang

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 11:55 AM, Fengguang Wu wrote: > On Fri, Oct 26, 2012 at 11:38:11AM +0800, YingHang Zhu wrote: >> On Fri, Oct 26, 2012 at 8:25 AM, Dave Chinner wrote: >> > On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: >> >> Hi Chen, >> >> >> >> > But how can bdi related

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 11:51 AM, Ni zhan Chen wrote: > On 10/26/2012 11:28 AM, YingHang Zhu wrote: >> >> On Fri, Oct 26, 2012 at 10:30 AM, Ni zhan Chen >> wrote: >>> >>> On 10/26/2012 09:27 AM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: >

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 11:38:11AM +0800, YingHang Zhu wrote: > On Fri, Oct 26, 2012 at 8:25 AM, Dave Chinner wrote: > > On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: > >> Hi Chen, > >> > >> > But how can bdi related ra_pages reflect different files' readahead > >> > window? Maybe

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 11:28 AM, YingHang Zhu wrote: On Fri, Oct 26, 2012 at 10:30 AM, Ni zhan Chen wrote: On 10/26/2012 09:27 AM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 8:25 AM, Dave Chinner wrote: > On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: >> Hi Chen, >> >> > But how can bdi related ra_pages reflect different files' readahead >> > window? Maybe these different files are sequential read, random read >> > and so on. >>

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 10:30 AM, Ni zhan Chen wrote: > On 10/26/2012 09:27 AM, Fengguang Wu wrote: >> >> On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: >>> >>> On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, > But how can bdi related

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 09:27 AM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 08:25 AM, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are sequential read, random read and so on. It's simple: sequential reads

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: > On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: > > Hi Chen, > > > > > But how can bdi related ra_pages reflect different files' readahead > > > window? Maybe these different files are sequential read, random read > > >

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Dave Chinner
On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: > Hi Chen, > > > But how can bdi related ra_pages reflect different files' readahead > > window? Maybe these different files are sequential read, random read > > and so on. > > It's simple: sequential reads will get ra_pages readahead

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Dave Chinner
On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are sequential read, random read and so on. It's simple: sequential reads will get ra_pages readahead size

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are sequential read, random read and so on.

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 08:25 AM, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are sequential read, random read and so on. It's simple: sequential reads

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 09:27 AM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 10:30 AM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/26/2012 09:27 AM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 8:25 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are sequential read, random read and so

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 11:28 AM, YingHang Zhu wrote: On Fri, Oct 26, 2012 at 10:30 AM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/26/2012 09:27 AM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 11:38:11AM +0800, YingHang Zhu wrote: On Fri, Oct 26, 2012 at 8:25 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window?

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 11:51 AM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/26/2012 11:28 AM, YingHang Zhu wrote: On Fri, Oct 26, 2012 at 10:30 AM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/26/2012 09:27 AM, Fengguang Wu wrote: On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread YingHang Zhu
On Fri, Oct 26, 2012 at 11:55 AM, Fengguang Wu fengguang...@intel.com wrote: On Fri, Oct 26, 2012 at 11:38:11AM +0800, YingHang Zhu wrote: On Fri, Oct 26, 2012 at 8:25 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: Hi Chen, But

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Fengguang Wu
Hi Chen, > But how can bdi related ra_pages reflect different files' readahead > window? Maybe these different files are sequential read, random read > and so on. It's simple: sequential reads will get ra_pages readahead size while random reads will not get readahead at all. Talking about the

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 10:58 AM, Fengguang Wu wrote: > Hi Chen, > >> But how can bdi related ra_pages reflect different files' readahead >> window? Maybe these different files are sequential read, random read >> and so on. > > It's simple: sequential reads will get ra_pages readahead size while

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 10:38 AM, Fengguang Wu wrote: > Hi YingHang, > >> Actually I've talked about it with Fengguang, he advised we should unify the >> ra_pages in struct bdi and file_ra_state and leave the issue that >> spreading data >> across disks as it is. >> Fengguang, what's you opinion

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Fengguang Wu
Hi YingHang, > Actually I've talked about it with Fengguang, he advised we should unify the > ra_pages in struct bdi and file_ra_state and leave the issue that > spreading data > across disks as it is. > Fengguang, what's you opinion about this? Yeah the two ra_pages may run out of sync for

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 10:12 AM, Ni zhan Chen wrote: > On 10/25/2012 10:04 AM, YingHang Zhu wrote: >> >> On Thu, Oct 25, 2012 at 9:50 AM, Dave Chinner wrote: >>> >>> On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Ni zhan Chen
On 10/25/2012 10:04 AM, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 9:50 AM, Dave Chinner wrote: On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 9:50 AM, Dave Chinner wrote: > On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: >> On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner wrote: >> > On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: >> >> Hi Dave, >> >> On Wed, Oct 24, 2012 at 6:47 AM,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Dave Chinner
On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: > On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner wrote: > > On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: > >> Hi Dave, > >> On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner wrote: > >> > On Tue, Oct 23, 2012 at 08:46:51PM

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Ni zhan Chen
On 10/25/2012 08:17 AM, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner wrote: On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: Hi,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner wrote: > On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: >> Hi Dave, >> On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner wrote: >> > On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: >> >> Hi, >> >> Recently we ran into the bug

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Dave Chinner
On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: > Hi Dave, > On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner wrote: > > On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: > >> Hi, > >> Recently we ran into the bug that an opened file's ra_pages does not > >> synchronize with

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Dave Chinner
On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner da...@fromorbit.com wrote: On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner da...@fromorbit.com wrote: On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: Hi, Recently

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Ni zhan Chen
On 10/25/2012 08:17 AM, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner da...@fromorbit.com wrote: On Tue, Oct 23, 2012 at

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Dave Chinner
On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner da...@fromorbit.com wrote: On Tue,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 9:50 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Ni zhan Chen
On 10/25/2012 10:04 AM, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 9:50 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 10:12 AM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/25/2012 10:04 AM, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 9:50 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Fengguang Wu
Hi YingHang, Actually I've talked about it with Fengguang, he advised we should unify the ra_pages in struct bdi and file_ra_state and leave the issue that spreading data across disks as it is. Fengguang, what's you opinion about this? Yeah the two ra_pages may run out of sync for already

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 10:38 AM, Fengguang Wu fengguang...@intel.com wrote: Hi YingHang, Actually I've talked about it with Fengguang, he advised we should unify the ra_pages in struct bdi and file_ra_state and leave the issue that spreading data across disks as it is. Fengguang, what's

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread YingHang Zhu
On Thu, Oct 25, 2012 at 10:58 AM, Fengguang Wu fengguang...@intel.com wrote: Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are sequential read, random read and so on. It's simple: sequential reads will get ra_pages readahead

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Fengguang Wu
Hi Chen, But how can bdi related ra_pages reflect different files' readahead window? Maybe these different files are sequential read, random read and so on. It's simple: sequential reads will get ra_pages readahead size while random reads will not get readahead at all. Talking about the

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread YingHang Zhu
Hi Chen, On Wed, Oct 24, 2012 at 9:02 AM, Ni zhan Chen wrote: > On 10/23/2012 09:41 PM, YingHang Zhu wrote: >> >> Sorry for the annoying, I forgot ccs in the previous mail. >> Thanks, >> Ying Zhu >> Hi Chen, >> >> On Tue, Oct 23, 2012 at 9:21 PM, Ni zhan Chen >> wrote: >>> >>> On

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Ni zhan Chen
On 10/23/2012 09:41 PM, YingHang Zhu wrote: Sorry for the annoying, I forgot ccs in the previous mail. Thanks, Ying Zhu Hi Chen, On Tue, Oct 23, 2012 at 9:21 PM, Ni zhan Chen wrote: On 10/23/2012 08:46 PM, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread YingHang Zhu
Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner wrote: > On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: >> Hi, >> Recently we ran into the bug that an opened file's ra_pages does not >> synchronize with it's backing device's when the latter is changed >> with blockdev --setra,

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Dave Chinner
On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: > Hi, > Recently we ran into the bug that an opened file's ra_pages does not > synchronize with it's backing device's when the latter is changed > with blockdev --setra, the application needs to reopen the file > to know the change, or

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread YingHang Zhu
Sorry for the annoying, I forgot ccs in the previous mail. Thanks, Ying Zhu Hi Chen, On Tue, Oct 23, 2012 at 9:21 PM, Ni zhan Chen wrote: > On 10/23/2012 08:46 PM, Ying Zhu wrote: >> >> Hi, >>Recently we ran into the bug that an opened file's ra_pages does not >> synchronize with

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Ni zhan Chen
On 10/23/2012 08:46 PM, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize with it's backing device's when the latter is changed with blockdev --setra, the application needs to reopen the file to know the change, which is inappropriate under

[PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Ying Zhu
Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize with it's backing device's when the latter is changed with blockdev --setra, the application needs to reopen the file to know the change, which is inappropriate under our circumstances. This bug is also

[PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Ying Zhu
Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize with it's backing device's when the latter is changed with blockdev --setra, the application needs to reopen the file to know the change, which is inappropriate under our circumstances. This bug is also

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Ni zhan Chen
On 10/23/2012 08:46 PM, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize with it's backing device's when the latter is changed with blockdev --setra, the application needs to reopen the file to know the change, which is inappropriate under

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread YingHang Zhu
Sorry for the annoying, I forgot ccs in the previous mail. Thanks, Ying Zhu Hi Chen, On Tue, Oct 23, 2012 at 9:21 PM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/23/2012 08:46 PM, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's ra_pages does not

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Dave Chinner
On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize with it's backing device's when the latter is changed with blockdev --setra, the application needs to reopen the file to know the change, or simply

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread YingHang Zhu
Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner da...@fromorbit.com wrote: On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize with it's backing device's when the latter is changed with

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Ni zhan Chen
On 10/23/2012 09:41 PM, YingHang Zhu wrote: Sorry for the annoying, I forgot ccs in the previous mail. Thanks, Ying Zhu Hi Chen, On Tue, Oct 23, 2012 at 9:21 PM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/23/2012 08:46 PM, Ying Zhu wrote: Hi, Recently we ran into the bug

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread YingHang Zhu
Hi Chen, On Wed, Oct 24, 2012 at 9:02 AM, Ni zhan Chen nizhan.c...@gmail.com wrote: On 10/23/2012 09:41 PM, YingHang Zhu wrote: Sorry for the annoying, I forgot ccs in the previous mail. Thanks, Ying Zhu Hi Chen, On Tue, Oct 23, 2012 at 9:21 PM, Ni zhan Chen