Re: [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth

2016-09-21 Thread Jaehoon Chung 
On 09/21/2016 11:40 AM, Shawn Lin wrote:
> msize and rx_wmark are properly initialized, we dont't
> need to assign them again.

Applied on my tree. Thanks!

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Shawn Lin 
> ---
> 
>  drivers/mmc/host/dw_mmc.c | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 22dacae..d838428 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, 
> struct mmc_data *data)
>* MSIZE is '1',
>* if blksz is not a multiple of the FIFO width
>*/
> - if (blksz % fifo_width) {
> - msize = 0;
> - rx_wmark = 1;
> + if (blksz % fifo_width)
>   goto done;
> - }
>  
>   do {
>   if (!((blksz_depth % mszs[idx]) ||
>

Re: [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth

2016-09-21 Thread Jaehoon Chung 
On 09/21/2016 11:40 AM, Shawn Lin wrote:
> msize and rx_wmark are properly initialized, we dont't
> need to assign them again.

Applied on my tree. Thanks!

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Shawn Lin 
> ---
> 
>  drivers/mmc/host/dw_mmc.c | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 22dacae..d838428 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, 
> struct mmc_data *data)
>* MSIZE is '1',
>* if blksz is not a multiple of the FIFO width
>*/
> - if (blksz % fifo_width) {
> - msize = 0;
> - rx_wmark = 1;
> + if (blksz % fifo_width)
>   goto done;
> - }
>  
>   do {
>   if (!((blksz_depth % mszs[idx]) ||
>

[PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth

2016-09-20 Thread Shawn Lin 
msize and rx_wmark are properly initialized, we dont't
need to assign them again.

Signed-off-by: Shawn Lin 
---

 drivers/mmc/host/dw_mmc.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 22dacae..d838428 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, 
struct mmc_data *data)
 * MSIZE is '1',
 * if blksz is not a multiple of the FIFO width
 */
-   if (blksz % fifo_width) {
-   msize = 0;
-   rx_wmark = 1;
+   if (blksz % fifo_width)
goto done;
-   }
 
do {
if (!((blksz_depth % mszs[idx]) ||
-- 
2.3.7

[PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth

2016-09-20 Thread Shawn Lin 
msize and rx_wmark are properly initialized, we dont't
need to assign them again.

Signed-off-by: Shawn Lin 
---

 drivers/mmc/host/dw_mmc.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 22dacae..d838428 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, 
struct mmc_data *data)
 * MSIZE is '1',
 * if blksz is not a multiple of the FIFO width
 */
-   if (blksz % fifo_width) {
-   msize = 0;
-   rx_wmark = 1;
+   if (blksz % fifo_width)
goto done;
-   }
 
do {
if (!((blksz_depth % mszs[idx]) ||
-- 
2.3.7