Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Mauro Carvalho Chehab
Hi Andrew, Em Seg, 2007-09-17 às 14:50 -0700, Andrew Morton escreveu: > On Tue, 18 Sep 2007 03:15:14 +0530 (IST) > Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > > > > > On Sun, 16 Sep 2007, Andrew Morton wrote: > > > > > On Mon, 17 Sep 2007 05:54:45 +0530 "Satyam Sharma" <[EMAIL PROTECTED]>

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Andrew Morton
On Tue, 18 Sep 2007 03:15:14 +0530 (IST) Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > On Sun, 16 Sep 2007, Andrew Morton wrote: > > > On Mon, 17 Sep 2007 05:54:45 +0530 "Satyam Sharma" <[EMAIL PROTECTED]> > > wrote: > > > > > On 9/17/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > >

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Satyam Sharma
On Sun, 16 Sep 2007, Andrew Morton wrote: > On Mon, 17 Sep 2007 05:54:45 +0530 "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > > > On 9/17/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > I'm getting this: > > > > > > rusb2/pvrusb2: struct usb_device_id is 20 bytes. The last of 3 is: > >

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Andrew Morton
On Sun, 16 Sep 2007 20:45:54 -0700 Kees Cook <[EMAIL PROTECTED]> wrote: > The cleanups you suggested, who should I send those to? Or will you (or > Sam?) make them directly to the kbuild.git tree? (I've never poked at > this part of the kernel source before... I'm unclear on the processes >

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Andrew Morton
On Mon, 17 Sep 2007 05:54:45 +0530 "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > On 9/17/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook <[EMAIL PROTECTED]> wrote: > > > > > This patch against 2.6.23-rc6 will cause modpost to fail if any device > > >

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Andrew Morton
On Mon, 17 Sep 2007 05:54:45 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: On 9/17/07, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook [EMAIL PROTECTED] wrote: This patch against 2.6.23-rc6 will cause modpost to fail if any device id lists are

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Andrew Morton
On Sun, 16 Sep 2007 20:45:54 -0700 Kees Cook [EMAIL PROTECTED] wrote: The cleanups you suggested, who should I send those to? Or will you (or Sam?) make them directly to the kbuild.git tree? (I've never poked at this part of the kernel source before... I'm unclear on the processes

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Satyam Sharma
On Sun, 16 Sep 2007, Andrew Morton wrote: On Mon, 17 Sep 2007 05:54:45 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: On 9/17/07, Andrew Morton [EMAIL PROTECTED] wrote: I'm getting this: rusb2/pvrusb2: struct usb_device_id is 20 bytes. The last of 3 is: 0x03 0x00 0x00 0x00

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Andrew Morton
On Tue, 18 Sep 2007 03:15:14 +0530 (IST) Satyam Sharma [EMAIL PROTECTED] wrote: On Sun, 16 Sep 2007, Andrew Morton wrote: On Mon, 17 Sep 2007 05:54:45 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: On 9/17/07, Andrew Morton [EMAIL PROTECTED] wrote: I'm getting this:

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-17 Thread Mauro Carvalho Chehab
Hi Andrew, Em Seg, 2007-09-17 às 14:50 -0700, Andrew Morton escreveu: On Tue, 18 Sep 2007 03:15:14 +0530 (IST) Satyam Sharma [EMAIL PROTECTED] wrote: On Sun, 16 Sep 2007, Andrew Morton wrote: On Mon, 17 Sep 2007 05:54:45 +0530 Satyam Sharma [EMAIL PROTECTED] wrote:

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Kees Cook
Hi Satyam, On Mon, Sep 17, 2007 at 06:52:52AM +0530, Satyam Sharma wrote: > On 9/13/07, Kees Cook <[EMAIL PROTECTED]> wrote: > > > > This patch against 2.6.23-rc6 will cause modpost to fail if any device > > id lists are incorrectly terminated, after reporting the offender. > > > > Signed-off-by:

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Satyam Sharma
Hi Kees, On 9/13/07, Kees Cook <[EMAIL PROTECTED]> wrote: > > This patch against 2.6.23-rc6 will cause modpost to fail if any device > id lists are incorrectly terminated, after reporting the offender. > > Signed-off-by: Kees Cook <[EMAIL PROTECTED]> Nice! :-) BTW a very similar idea (but for

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Satyam Sharma
On 9/17/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook <[EMAIL PROTECTED]> wrote: > > > This patch against 2.6.23-rc6 will cause modpost to fail if any device > > id lists are incorrectly terminated, after reporting the offender. > > I'm getting this: >

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Andrew Morton
On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook <[EMAIL PROTECTED]> wrote: > This patch against 2.6.23-rc6 will cause modpost to fail if any device > id lists are incorrectly terminated, after reporting the offender. I'm getting this: rusb2/pvrusb2: struct usb_device_id is 20 bytes. The last of 3

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Andrew Morton
On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook [EMAIL PROTECTED] wrote: This patch against 2.6.23-rc6 will cause modpost to fail if any device id lists are incorrectly terminated, after reporting the offender. I'm getting this: rusb2/pvrusb2: struct usb_device_id is 20 bytes. The last of 3 is:

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Satyam Sharma
On 9/17/07, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook [EMAIL PROTECTED] wrote: This patch against 2.6.23-rc6 will cause modpost to fail if any device id lists are incorrectly terminated, after reporting the offender. I'm getting this:

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Satyam Sharma
Hi Kees, On 9/13/07, Kees Cook [EMAIL PROTECTED] wrote: This patch against 2.6.23-rc6 will cause modpost to fail if any device id lists are incorrectly terminated, after reporting the offender. Signed-off-by: Kees Cook [EMAIL PROTECTED] Nice! :-) BTW a very similar idea (but for a

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-16 Thread Kees Cook
Hi Satyam, On Mon, Sep 17, 2007 at 06:52:52AM +0530, Satyam Sharma wrote: On 9/13/07, Kees Cook [EMAIL PROTECTED] wrote: This patch against 2.6.23-rc6 will cause modpost to fail if any device id lists are incorrectly terminated, after reporting the offender. Signed-off-by: Kees Cook

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook <[EMAIL PROTECTED]> wrote: > On Wed, Sep 12, 2007 at 02:53:56PM -0700, Greg KH wrote: > > On Wed, Sep 12, 2007 at 03:48:49PM +0400, Alexey Dobriyan wrote: > > > On 9/12/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > > Kees Cook wrote: > > > > > This

[PATCH] modpost: detect unterminated device id lists

2007-09-12 Thread Kees Cook
On Wed, Sep 12, 2007 at 02:53:56PM -0700, Greg KH wrote: > On Wed, Sep 12, 2007 at 03:48:49PM +0400, Alexey Dobriyan wrote: > > On 9/12/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > Kees Cook wrote: > > > > This patch against 2.6.23-rc6 fixes a couple drivers that do not > > > > correctly

[PATCH] modpost: detect unterminated device id lists

2007-09-12 Thread Kees Cook
On Wed, Sep 12, 2007 at 02:53:56PM -0700, Greg KH wrote: On Wed, Sep 12, 2007 at 03:48:49PM +0400, Alexey Dobriyan wrote: On 9/12/07, Jeff Garzik [EMAIL PROTECTED] wrote: Kees Cook wrote: This patch against 2.6.23-rc6 fixes a couple drivers that do not correctly terminate their

Re: [PATCH] modpost: detect unterminated device id lists

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook [EMAIL PROTECTED] wrote: On Wed, Sep 12, 2007 at 02:53:56PM -0700, Greg KH wrote: On Wed, Sep 12, 2007 at 03:48:49PM +0400, Alexey Dobriyan wrote: On 9/12/07, Jeff Garzik [EMAIL PROTECTED] wrote: Kees Cook wrote: This patch against