Re: [PATCH] module: make module symbols visible after init

2020-06-04 Thread chengjian (D)
Hi, Petr, Jessica and Miroslav Thank you for your reply On 2020/6/4 16:57, Petr Mladek wrote: On Wed 2020-06-03 14:12:00, Cheng Jian wrote: It is really handful that module symbols can be found already when the module is MODULE_STATE_COMING state. It is used by livepatching, ftrace, and maybe

Re: [PATCH] module: make module symbols visible after init

2020-06-04 Thread Jessica Yu
+++ Miroslav Benes [03/06/20 19:00 +0200]: In commit 0bd476e6c671 ("kallsyms: unexport kallsyms_lookup_name() and kallsyms_on_each_symbol()") restricts the invocation for kernel unexported symbols, but it is still incorrect to make the symbols of non-LIVE modules visible to the outside. Why?

Re: [PATCH] module: make module symbols visible after init

2020-06-04 Thread Petr Mladek
On Wed 2020-06-03 14:12:00, Cheng Jian wrote: > When lookup the symbols of module by module_kallsyms_lookup_name(), > the symbols address is visible only if the module's status isn't > MODULE_STATE_UNFORMED, This is problematic. > > When complete_formation is done, the state of the module is

Re: [PATCH] module: make module symbols visible after init

2020-06-03 Thread Miroslav Benes
Hi, I'm confused... On Wed, 3 Jun 2020, Cheng Jian wrote: > When lookup the symbols of module by module_kallsyms_lookup_name(), > the symbols address is visible only if the module's status isn't > MODULE_STATE_UNFORMED, This is problematic. > > When complete_formation is done, the state of the

[PATCH] module: make module symbols visible after init

2020-06-03 Thread Cheng Jian
When lookup the symbols of module by module_kallsyms_lookup_name(), the symbols address is visible only if the module's status isn't MODULE_STATE_UNFORMED, This is problematic. When complete_formation is done, the state of the module is modified to MODULE_STATE_COMING, and the symbol of module is