Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-05-14 Thread Martin K. Petersen
Luc, >> You forgot to update the function prototype accordingly. > > Hmmm, the function mpt_lan_sdu_send() has no other declaration > than the one I modified the return type in this patch. > > Must be a misunderstanding somewhere. My bad, I thought you were updating mpt_lan_send_reply().

Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-05-08 Thread Luc Van Oostenryck
On Tue, May 08, 2018 at 01:21:56AM -0400, Martin K. Petersen wrote: > > Luc, > > > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > > which is a typedef for an enum type, but the implementation in this > > driver returns an 'int'. > > You forgot to update the function

Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-05-07 Thread Martin K. Petersen
Luc, > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. You forgot to update the function prototype accordingly. -- Martin K. Petersen Oracle Linux Engineering

[PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---