Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-07 Thread Brian Norris
On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: > Calling mtd_device_parse_register with the same mtd_info > (e.g. registering several partitions on a single device) > would add the same reboot notifier twice, causing an > infinte loop in notifier_chain_register during boot up. > >

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-07 Thread Brian Norris
On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: Calling mtd_device_parse_register with the same mtd_info (e.g. registering several partitions on a single device) would add the same reboot notifier twice, causing an infinte loop in notifier_chain_register during boot up.

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-02 Thread Brian Norris
On Mon, Feb 02, 2015 at 10:01:51AM +0100, Ricard Wanderlof wrote: > > > On 02/02/2015 12:07 AM, Brian Norris wrote: > > > > > > No driver should be calling mtd_device_parse_register() multiple times > > > on the same mtd_info. Under what context do you see this? What driver? > >

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-02 Thread Ricard Wanderlof
> On 02/02/2015 12:07 AM, Brian Norris wrote: > > > > No driver should be calling mtd_device_parse_register() multiple times > > on the same mtd_info. Under what context do you see this? What driver? > arch/cris/arch-v32/drivers/axisflashmap.c Looking at it another way, why should it not be

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-02 Thread Brian Norris
On Mon, Feb 02, 2015 at 08:08:17AM +0100, Niklas Cassel wrote: > > On 02/02/2015 12:07 AM, Brian Norris wrote: > > On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: > >> Calling mtd_device_parse_register with the same mtd_info > >> (e.g. registering several partitions on a single

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-02 Thread Brian Norris
On Mon, Feb 02, 2015 at 08:08:17AM +0100, Niklas Cassel wrote: On 02/02/2015 12:07 AM, Brian Norris wrote: On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: Calling mtd_device_parse_register with the same mtd_info (e.g. registering several partitions on a single device)

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-02 Thread Ricard Wanderlof
On 02/02/2015 12:07 AM, Brian Norris wrote: No driver should be calling mtd_device_parse_register() multiple times on the same mtd_info. Under what context do you see this? What driver? arch/cris/arch-v32/drivers/axisflashmap.c Looking at it another way, why should it not be allowed, if

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-02 Thread Brian Norris
On Mon, Feb 02, 2015 at 10:01:51AM +0100, Ricard Wanderlof wrote: On 02/02/2015 12:07 AM, Brian Norris wrote: No driver should be calling mtd_device_parse_register() multiple times on the same mtd_info. Under what context do you see this? What driver?

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-01 Thread Niklas Cassel
On 02/02/2015 12:07 AM, Brian Norris wrote: > On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: >> Calling mtd_device_parse_register with the same mtd_info >> (e.g. registering several partitions on a single device) >> would add the same reboot notifier twice, causing an >> infinte

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-01 Thread Brian Norris
On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: > Calling mtd_device_parse_register with the same mtd_info > (e.g. registering several partitions on a single device) > would add the same reboot notifier twice, causing an > infinte loop in notifier_chain_register during boot up. No

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-01 Thread Brian Norris
On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: Calling mtd_device_parse_register with the same mtd_info (e.g. registering several partitions on a single device) would add the same reboot notifier twice, causing an infinte loop in notifier_chain_register during boot up. No

Re: [PATCH] mtd: avoid registering reboot notifier twice

2015-02-01 Thread Niklas Cassel
On 02/02/2015 12:07 AM, Brian Norris wrote: On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: Calling mtd_device_parse_register with the same mtd_info (e.g. registering several partitions on a single device) would add the same reboot notifier twice, causing an infinte loop in

[PATCH] mtd: avoid registering reboot notifier twice

2015-01-31 Thread Niklas Cassel
Calling mtd_device_parse_register with the same mtd_info (e.g. registering several partitions on a single device) would add the same reboot notifier twice, causing an infinte loop in notifier_chain_register during boot up. Signed-off-by: Niklas Cassel --- drivers/mtd/mtdcore.c | 2 +- 1 file

[PATCH] mtd: avoid registering reboot notifier twice

2015-01-31 Thread Niklas Cassel
Calling mtd_device_parse_register with the same mtd_info (e.g. registering several partitions on a single device) would add the same reboot notifier twice, causing an infinte loop in notifier_chain_register during boot up. Signed-off-by: Niklas Cassel n...@flawful.org --- drivers/mtd/mtdcore.c |