Re: [PATCH] mtd: fsl_ifc_nand: use devm_ functions consistently

2014-09-27 Thread Brian Norris
+ linux-mtd FYI, I addressed a similar patch over here: http://lists.infradead.org/pipermail/linux-mtd/2014-September/055563.html I'm pretty sure this patch is wrong, and the semantic match is incorrect (or at least, it has false positives). Just because devm_* is used in some part of the

Re: [PATCH] mtd: fsl_ifc_nand: use devm_ functions consistently

2014-09-27 Thread Brian Norris
+ linux-mtd FYI, I addressed a similar patch over here: http://lists.infradead.org/pipermail/linux-mtd/2014-September/055563.html I'm pretty sure this patch is wrong, and the semantic match is incorrect (or at least, it has false positives). Just because devm_* is used in some part of the

[PATCH] mtd: fsl_ifc_nand: use devm_ functions consistently

2014-08-03 Thread Himangi Saraogi
Use devm_kzalloc for all calls to kzalloc and not just the first. Use devm functions for other allocations as well. The calls to free the allocated memory in the remove function are done away with. The semantic match that finds the inconsistency is as follows: // @@ @@ *devm_kzalloc(...) ...

[PATCH] mtd: fsl_ifc_nand: use devm_ functions consistently

2014-08-03 Thread Himangi Saraogi
Use devm_kzalloc for all calls to kzalloc and not just the first. Use devm functions for other allocations as well. The calls to free the allocated memory in the remove function are done away with. The semantic match that finds the inconsistency is as follows: // smpl @@ @@ *devm_kzalloc(...)