Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Tue, Nov 22, 2016 at 01:32:27PM -0800, Joe Perches wrote: > On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote: > > Thanks, these all look good but: > > > > (a) you didn't provide a Signed-off-by and > > (b) your patch is full of non-breaking spaces (0xA0), instead of proper > > ASCII

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Tue, Nov 22, 2016 at 01:32:27PM -0800, Joe Perches wrote: > On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote: > > Thanks, these all look good but: > > > > (a) you didn't provide a Signed-off-by and > > (b) your patch is full of non-breaking spaces (0xA0), instead of proper > > ASCII

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote: > On Fri, Oct 28, 2016 at 11:51:47AM -0700, Joe Perches wrote: > > I'd suggest as well fixing all the dev_ uses > > to be a consistent form: (this also fixes the typo) > > and a few other bits > > > > o Coalesce formats > > o Realign

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote: > On Fri, Oct 28, 2016 at 11:51:47AM -0700, Joe Perches wrote: > > I'd suggest as well fixing all the dev_ uses > > to be a consistent form: (this also fixes the typo) > > and a few other bits > > > > o Coalesce formats > > o Realign

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Fri, Oct 28, 2016 at 11:51:47AM -0700, Joe Perches wrote: > I'd suggest as well fixing all the dev_ uses > to be a consistent form: (this also fixes the typo) > and a few other bits > > o Coalesce formats > o Realign arguments > o Add missing newlines Yeah, Colin missed this on the line he

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Fri, Oct 28, 2016 at 11:51:47AM -0700, Joe Perches wrote: > I'd suggest as well fixing all the dev_ uses > to be a consistent form: (this also fixes the typo) > and a few other bits > > o Coalesce formats > o Realign arguments > o Add missing newlines Yeah, Colin missed this on the line he

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Fri, Oct 28, 2016 at 07:25:59PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King > --- > drivers/mtd/mtdswap.c | 2 +- > 1 file changed, 1

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

On Fri, Oct 28, 2016 at 07:25:59PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King > --- > drivers/mtd/mtdswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

I'd suggest as well fixing all the dev_ uses to be a consistent form: (this also fixes the typo) and a few other bits o Coalesce formats o Realign arguments o Add missing newlines o Convert printk(KERN_ to pr_( o Add #define pr_fmt, remove MTDSWAP_PREFIX Reduces object size a little too ---  

Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

I'd suggest as well fixing all the dev_ uses to be a consistent form: (this also fixes the typo) and a few other bits o Coalesce formats o Realign arguments o Add missing newlines o Convert printk(KERN_ to pr_( o Add #define pr_fmt, remove MTDSWAP_PREFIX Reduces object size a little too ---  

[PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

From: Colin Ian King Trivial fix to spelling mistake in dev_err message Signed-off-by: Colin Ian King --- drivers/mtd/mtdswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c

[PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

From: Colin Ian King Trivial fix to spelling mistake in dev_err message Signed-off-by: Colin Ian King --- drivers/mtd/mtdswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index cb06bdd..d0402df 100644 ---

[PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

From: Colin Ian King Trivial fix to spelling mistake in dev_err message Signed-off-by: Colin Ian King --- drivers/mtd/mtdswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c

[PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

From: Colin Ian King Trivial fix to spelling mistake in dev_err message Signed-off-by: Colin Ian King --- drivers/mtd/mtdswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index cb06bdd..d0402df 100644 ---