Re: [PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request_chan() failed

2016-08-29 Thread Brian Norris
On Mon, Aug 15, 2016 at 05:22:00PM +0200, Boris Brezillon wrote: > On Mon, 15 Aug 2016 10:47:39 +0300 > Roger Quadros wrote: > > > dma_request_chan() can fail returning an error pointer. In this case > > prevent calling dma_release_channel() to prevent a ERR_PTR() dereference. > > > > As error p

Re: [PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request_chan() failed

2016-08-15 Thread Boris Brezillon
On Mon, 15 Aug 2016 10:47:39 +0300 Roger Quadros wrote: > dma_request_chan() can fail returning an error pointer. In this case > prevent calling dma_release_channel() to prevent a ERR_PTR() dereference. > > As error path can be called even with no DMA configuration, info->dma can > be NULL so do

[PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request_chan() failed

2016-08-15 Thread Roger Quadros
dma_request_chan() can fail returning an error pointer. In this case prevent calling dma_release_channel() to prevent a ERR_PTR() dereference. As error path can be called even with no DMA configuration, info->dma can be NULL so don't call dma_release_channel() for that case either. Fixes: de3bfc4