Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 23:02:29 +0800 (CST) liuxiang wrote: > Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale > QuadSPI driver") 12 digits should be enough for the commit-id. > Cc: sta...@vger.kernel.org > > Should I send a V2 patch that adds these above？ Yes

Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 23:02:29 +0800 (CST) liuxiang wrote: > Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale > QuadSPI driver") 12 digits should be enough for the commit-id. > Cc: sta...@vger.kernel.org > > Should I send a V2 patch that adds these above？ Yes

Re:Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread liuxiang
Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale QuadSPI driver") Cc: sta...@vger.kernel.org Should I send a V2 patch that adds these above？ At 2018-08-27 16:06:13, "Boris Brezillon" wrote: >On Sat, 18 Aug 2018 17:14:23 +0800 >Liu Xiang wrote: > >> If the size

Re:Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread liuxiang
Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale QuadSPI driver") Cc: sta...@vger.kernel.org Should I send a V2 patch that adds these above？ At 2018-08-27 16:06:13, "Boris Brezillon" wrote: >On Sat, 18 Aug 2018 17:14:23 +0800 >Liu Xiang wrote: > >> If the size

Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Sat, 18 Aug 2018 17:14:23 +0800 Liu Xiang wrote: > If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > >

Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Sat, 18 Aug 2018 17:14:23 +0800 Liu Xiang wrote: > If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > >

[PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-18 Thread Liu Xiang
If the size of spi-nor flash is larger than 16MB, the read_opcode is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can cause read operation fail. Signed-off-by: Liu Xiang --- drivers/mtd/spi-nor/fsl-quadspi.c | 1 + 1 file

[PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-18 Thread Liu Xiang
If the size of spi-nor flash is larger than 16MB, the read_opcode is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can cause read operation fail. Signed-off-by: Liu Xiang --- drivers/mtd/spi-nor/fsl-quadspi.c | 1 + 1 file