Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Russell King - ARM Linux
On Mon, Nov 09, 2015 at 06:08:49PM +0100, Andrew Lunn wrote: > You use fixed-phy when the MAC is connected to a switch, not a phy. Or > when the MAC is connected to an SFP module. ... hopefully not for much longer. Once -rc1 is out, I'll sort out posting my phylink and SFP module hotplug support

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Russell King - ARM Linux
On Mon, Nov 09, 2015 at 06:12:02PM +0100, Arnd Bergmann wrote: > On Monday 09 November 2015 17:08:34 Russell King - ARM Linux wrote: > > They are "optional" because when you're using a DSA switch, you don't > > specify a PHY (because, there isn't one). For example, this is what > > I'm using with

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 18:08:49 Andrew Lunn wrote: > > > I suppose it comes down to, are we allowed to optionally implement > > > part of the DT binding? > > > > I'm not sure what you are asking. A lot of DT bindings have both > > optional and mandatory properties. For mvneta, the "phy" and "p

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 17:08:34 Russell King - ARM Linux wrote: > They are "optional" because when you're using a DSA switch, you don't > specify a PHY (because, there isn't one). For example, this is what > I'm using with an Armada 388 board with a Marvell DSA switch. The > DSA does not appe

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Russell King - ARM Linux
On Mon, Nov 09, 2015 at 05:57:43PM +0100, Arnd Bergmann wrote: > I'm not sure what you are asking. A lot of DT bindings have both > optional and mandatory properties. For mvneta, the "phy" and "phy-mode" > properties are listed as mandatory, so the driver can safely assume > that they are always pr

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Andrew Lunn
> > I suppose it comes down to, are we allowed to optionally implement > > part of the DT binding? > > I'm not sure what you are asking. A lot of DT bindings have both > optional and mandatory properties. For mvneta, the "phy" and "phy-mode" > properties are listed as mandatory, so the driver can

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 17:42:32 Andrew Lunn wrote: > On Mon, Nov 09, 2015 at 03:08:57PM +0100, Arnd Bergmann wrote: > > The fixed_phy infrastructure is done in a way that is optional, > > by providing 'static inline' helper functions doing nothing in > > include/linux/phy_fixed.h for all its AP

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Andrew Lunn
On Mon, Nov 09, 2015 at 03:08:57PM +0100, Arnd Bergmann wrote: > The fixed_phy infrastructure is done in a way that is optional, > by providing 'static inline' helper functions doing nothing in > include/linux/phy_fixed.h for all its APIs. However, three out > of the four users (DSA, BCMGENET, and

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread David Miller
From: Arnd Bergmann Date: Mon, 09 Nov 2015 15:08:57 +0100 > The fixed_phy infrastructure is done in a way that is optional, > by providing 'static inline' helper functions doing nothing in > include/linux/phy_fixed.h for all its APIs. However, three out > of the four users (DSA, BCMGENET, and SYS

[PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
The fixed_phy infrastructure is done in a way that is optional, by providing 'static inline' helper functions doing nothing in include/linux/phy_fixed.h for all its APIs. However, three out of the four users (DSA, BCMGENET, and SYSTEMPORT) always 'select FIXED_PHY', presumably because they need tha