Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 17.11.2017 21:52, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 19:31, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> On 15.11.2017 12:51, Kirill Tkhai wrote: > On 15.11.2017 06:19, Eric W. Biederman wrote:

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 17.11.2017 21:52, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 19:31, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> On 15.11.2017 12:51, Kirill Tkhai wrote: > On 15.11.2017 06:19, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 17.11.2017 21:54, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 19:29, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> On 15.11.2017 09:25, Eric W. Biederman wrote: > Kirill Tkhai writes:

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 17.11.2017 21:54, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 19:29, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> On 15.11.2017 09:25, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> Curently mutex is used to protect pernet operations

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 19:29, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On 15.11.2017 09:25, Eric W. Biederman wrote: Kirill Tkhai writes: > Curently mutex is used to protect pernet

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 19:29, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On 15.11.2017 09:25, Eric W. Biederman wrote: Kirill Tkhai writes: > Curently mutex is used to protect pernet operations list. It makes > cleanup_net() to execute ->exit

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 19:31, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On 15.11.2017 12:51, Kirill Tkhai wrote: On 15.11.2017 06:19, Eric W. Biederman wrote: > Kirill Tkhai writes: >

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 19:31, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On 15.11.2017 12:51, Kirill Tkhai wrote: On 15.11.2017 06:19, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 14.11.2017 21:39, Cong Wang wrote: >>> On Tue, Nov 14,

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 19:31, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 12:51, Kirill Tkhai wrote: >>> On 15.11.2017 06:19, Eric W. Biederman wrote: Kirill Tkhai writes: > On 14.11.2017 21:39, Cong Wang wrote: >> On

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 19:31, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 12:51, Kirill Tkhai wrote: >>> On 15.11.2017 06:19, Eric W. Biederman wrote: Kirill Tkhai writes: > On 14.11.2017 21:39, Cong Wang wrote: >> On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 19:29, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 09:25, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> Curently mutex is used to protect pernet operations list. It makes cleanup_net() to execute

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 19:29, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 09:25, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> Curently mutex is used to protect pernet operations list. It makes cleanup_net() to execute ->exit methods of the same operations set,

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 19:29, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 09:25, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> Curently mutex is used to protect pernet operations list. It makes cleanup_net() to execute

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 19:29, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 15.11.2017 09:25, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> Curently mutex is used to protect pernet operations list. It makes cleanup_net() to execute ->exit methods of the same operations set,

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 12:51, Kirill Tkhai wrote: >> On 15.11.2017 06:19, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> On 14.11.2017 21:39, Cong Wang wrote: > On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 12:51, Kirill Tkhai wrote: >> On 15.11.2017 06:19, Eric W. Biederman wrote: >>> Kirill Tkhai writes: >>> On 14.11.2017 21:39, Cong Wang wrote: > On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai > wrote: >> @@ -406,7 +406,7 @@ struct net

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 09:25, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> Curently mutex is used to protect pernet operations list. It makes >>> cleanup_net() to execute ->exit methods of the same operations set, >>> which

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 15.11.2017 09:25, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> Curently mutex is used to protect pernet operations list. It makes >>> cleanup_net() to execute ->exit methods of the same operations set, >>> which was used on the time of ->init, even after

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 12:51, Kirill Tkhai wrote: > On 15.11.2017 06:19, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On 14.11.2017 21:39, Cong Wang wrote: On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: > @@ -406,7 +406,7 @@ struct net

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 12:51, Kirill Tkhai wrote: > On 15.11.2017 06:19, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On 14.11.2017 21:39, Cong Wang wrote: On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: > @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, >

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 06:19, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 14.11.2017 21:39, Cong Wang wrote: >>> On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags,

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 06:19, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> On 14.11.2017 21:39, Cong Wang wrote: >>> On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, get_user_ns(user_ns); -

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 09:25, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> Curently mutex is used to protect pernet operations list. It makes >> cleanup_net() to execute ->exit methods of the same operations set, >> which was used on the time of ->init, even after net

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 15.11.2017 09:25, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> Curently mutex is used to protect pernet operations list. It makes >> cleanup_net() to execute ->exit methods of the same operations set, >> which was used on the time of ->init, even after net namespace is >> unlinked

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > Curently mutex is used to protect pernet operations list. It makes > cleanup_net() to execute ->exit methods of the same operations set, > which was used on the time of ->init, even after net namespace is > unlinked from net_namespace_list. > > But

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > Curently mutex is used to protect pernet operations list. It makes > cleanup_net() to execute ->exit methods of the same operations set, > which was used on the time of ->init, even after net namespace is > unlinked from net_namespace_list. > > But the problem is it's need

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 14.11.2017 21:39, Cong Wang wrote: >> On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: >>> @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, >>> >>> get_user_ns(user_ns); >>> >>> - rv =

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Kirill Tkhai writes: > On 14.11.2017 21:39, Cong Wang wrote: >> On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: >>> @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, >>> >>> get_user_ns(user_ns); >>> >>> - rv = mutex_lock_killable(_mutex); >>> + rv =

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 10:00:59AM -0800, Eric Dumazet wrote: > On Tue, 2017-11-14 at 09:44 -0800, Andrei Vagin wrote: > > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > > > Curently mutex is used to protect pernet operations list. It makes > > > cleanup_net() to execute ->exit

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 10:00:59AM -0800, Eric Dumazet wrote: > On Tue, 2017-11-14 at 09:44 -0800, Andrei Vagin wrote: > > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > > > Curently mutex is used to protect pernet operations list. It makes > > > cleanup_net() to execute ->exit

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 21:38, Andrei Vagin wrote: > On Tue, Nov 14, 2017 at 09:04:06PM +0300, Kirill Tkhai wrote: >> On 14.11.2017 20:44, Andrei Vagin wrote: >>> On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: Curently mutex is used to protect pernet operations list. It makes

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 21:38, Andrei Vagin wrote: > On Tue, Nov 14, 2017 at 09:04:06PM +0300, Kirill Tkhai wrote: >> On 14.11.2017 20:44, Andrei Vagin wrote: >>> On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: Curently mutex is used to protect pernet operations list. It makes

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 21:39, Cong Wang wrote: > On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: >> @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, >> >> get_user_ns(user_ns); >> >> - rv = mutex_lock_killable(_mutex); >> + rv =

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 21:39, Cong Wang wrote: > On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: >> @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, >> >> get_user_ns(user_ns); >> >> - rv = mutex_lock_killable(_mutex); >> + rv = down_read_killable(_sem); >>

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 2017-11-14 at 10:11 -0800, Stephen Hemminger wrote: > On Tue, 14 Nov 2017 16:53:33 +0300 > Kirill Tkhai wrote: > > > + /* > > +* RCU-protected list, modifiable by pernet-init and -exit methods. > > +* When net namespace is alive (net::count > 0), all the

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 2017-11-14 at 10:11 -0800, Stephen Hemminger wrote: > On Tue, 14 Nov 2017 16:53:33 +0300 > Kirill Tkhai wrote: > > > + /* > > +* RCU-protected list, modifiable by pernet-init and -exit methods. > > +* When net namespace is alive (net::count > 0), all the changes > > +* are

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: > @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, > > get_user_ns(user_ns); > > - rv = mutex_lock_killable(_mutex); > + rv = down_read_killable(_sem); > if (rv < 0) { >

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote: > @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags, > > get_user_ns(user_ns); > > - rv = mutex_lock_killable(_mutex); > + rv = down_read_killable(_sem); > if (rv < 0) { > net_free(net);

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 09:04:06PM +0300, Kirill Tkhai wrote: > On 14.11.2017 20:44, Andrei Vagin wrote: > > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > >> Curently mutex is used to protect pernet operations list. It makes > >> cleanup_net() to execute ->exit methods of the

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 09:04:06PM +0300, Kirill Tkhai wrote: > On 14.11.2017 20:44, Andrei Vagin wrote: > > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > >> Curently mutex is used to protect pernet operations list. It makes > >> cleanup_net() to execute ->exit methods of the

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 14 Nov 2017 16:53:33 +0300 Kirill Tkhai wrote: > + /* > + * RCU-protected list, modifiable by pernet-init and -exit methods. > + * When net namespace is alive (net::count > 0), all the changes > + * are made under rw_sem held on write. > + */

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 14 Nov 2017 16:53:33 +0300 Kirill Tkhai wrote: > + /* > + * RCU-protected list, modifiable by pernet-init and -exit methods. > + * When net namespace is alive (net::count > 0), all the changes > + * are made under rw_sem held on write. > + */ > + struct

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 20:44, Andrei Vagin wrote: > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: >> Curently mutex is used to protect pernet operations list. It makes >> cleanup_net() to execute ->exit methods of the same operations set, >> which was used on the time of ->init, even after

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 20:44, Andrei Vagin wrote: > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: >> Curently mutex is used to protect pernet operations list. It makes >> cleanup_net() to execute ->exit methods of the same operations set, >> which was used on the time of ->init, even after

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 2017-11-14 at 09:44 -0800, Andrei Vagin wrote: > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > > Curently mutex is used to protect pernet operations list. It makes > > cleanup_net() to execute ->exit methods of the same operations set, > > which was used on the time of

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 2017-11-14 at 09:44 -0800, Andrei Vagin wrote: > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > > Curently mutex is used to protect pernet operations list. It makes > > cleanup_net() to execute ->exit methods of the same operations set, > > which was used on the time of

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > Curently mutex is used to protect pernet operations list. It makes > cleanup_net() to execute ->exit methods of the same operations set, > which was used on the time of ->init, even after net namespace is > unlinked from

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote: > Curently mutex is used to protect pernet operations list. It makes > cleanup_net() to execute ->exit methods of the same operations set, > which was used on the time of ->init, even after net namespace is > unlinked from

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 20:07, Eric Dumazet wrote: > On Tue, 2017-11-14 at 16:53 +0300, Kirill Tkhai wrote: >> Curently mutex is used to protect pernet operations list. It makes >> cleanup_net() to execute ->exit methods of the same operations set, >> which was used on the time of ->init, even after net

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On 14.11.2017 20:07, Eric Dumazet wrote: > On Tue, 2017-11-14 at 16:53 +0300, Kirill Tkhai wrote: >> Curently mutex is used to protect pernet operations list. It makes >> cleanup_net() to execute ->exit methods of the same operations set, >> which was used on the time of ->init, even after net

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 2017-11-14 at 16:53 +0300, Kirill Tkhai wrote: > Curently mutex is used to protect pernet operations list. It makes > cleanup_net() to execute ->exit methods of the same operations set, > which was used on the time of ->init, even after net namespace is > unlinked from net_namespace_list.

Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

On Tue, 2017-11-14 at 16:53 +0300, Kirill Tkhai wrote: > Curently mutex is used to protect pernet operations list. It makes > cleanup_net() to execute ->exit methods of the same operations set, > which was used on the time of ->init, even after net namespace is > unlinked from net_namespace_list.

[PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Curently mutex is used to protect pernet operations list. It makes cleanup_net() to execute ->exit methods of the same operations set, which was used on the time of ->init, even after net namespace is unlinked from net_namespace_list. But the problem is it's need to synchronize_rcu() after net is

[PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit

Curently mutex is used to protect pernet operations list. It makes cleanup_net() to execute ->exit methods of the same operations set, which was used on the time of ->init, even after net namespace is unlinked from net_namespace_list. But the problem is it's need to synchronize_rcu() after net is