Re: [PATCH] net: au1000 eth: simplify logical expression

2016-05-19 Thread David Miller
From: Heinrich Schuchardt 
Date: Wed, 18 May 2016 01:58:45 +0200

> (a && a > 0) is equivalent to (a > 0).
> 
> Signed-off-by: Heinrich Schuchardt 

Applied.


Re: [PATCH] net: au1000 eth: simplify logical expression

2016-05-19 Thread David Miller
From: Heinrich Schuchardt 
Date: Wed, 18 May 2016 01:58:45 +0200

> (a && a > 0) is equivalent to (a > 0).
> 
> Signed-off-by: Heinrich Schuchardt 

Applied.


Re: [PATCH] net: au1000 eth: simplify logical expression

2016-05-17 Thread Florian Fainelli
Le 17/05/2016 16:58, Heinrich Schuchardt a écrit :
> (a && a > 0) is equivalent to (a > 0).
> 
> Signed-off-by: Heinrich Schuchardt 

Acked-by: Florian Fainelli 
-- 
Florian


Re: [PATCH] net: au1000 eth: simplify logical expression

2016-05-17 Thread Florian Fainelli
Le 17/05/2016 16:58, Heinrich Schuchardt a écrit :
> (a && a > 0) is equivalent to (a > 0).
> 
> Signed-off-by: Heinrich Schuchardt 

Acked-by: Florian Fainelli 
-- 
Florian


[PATCH] net: au1000 eth: simplify logical expression

2016-05-17 Thread Heinrich Schuchardt
(a && a > 0) is equivalent to (a > 0).

Signed-off-by: Heinrich Schuchardt 
---
 drivers/net/ethernet/amd/au1000_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/au1000_eth.c 
b/drivers/net/ethernet/amd/au1000_eth.c
index 9af309e..e0fb0f1 100644
--- a/drivers/net/ethernet/amd/au1000_eth.c
+++ b/drivers/net/ethernet/amd/au1000_eth.c
@@ -1269,7 +1269,7 @@ static int au1000_probe(struct platform_device *pdev)
aup->phy_irq = pd->phy_irq;
}
 
-   if (aup->phy_busid && aup->phy_busid > 0) {
+   if (aup->phy_busid > 0) {
dev_err(>dev, "MAC0-associated PHY attached 2nd MACs MII 
bus not supported yet\n");
err = -ENODEV;
goto err_mdiobus_alloc;
-- 
2.1.4



[PATCH] net: au1000 eth: simplify logical expression

2016-05-17 Thread Heinrich Schuchardt
(a && a > 0) is equivalent to (a > 0).

Signed-off-by: Heinrich Schuchardt 
---
 drivers/net/ethernet/amd/au1000_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/au1000_eth.c 
b/drivers/net/ethernet/amd/au1000_eth.c
index 9af309e..e0fb0f1 100644
--- a/drivers/net/ethernet/amd/au1000_eth.c
+++ b/drivers/net/ethernet/amd/au1000_eth.c
@@ -1269,7 +1269,7 @@ static int au1000_probe(struct platform_device *pdev)
aup->phy_irq = pd->phy_irq;
}
 
-   if (aup->phy_busid && aup->phy_busid > 0) {
+   if (aup->phy_busid > 0) {
dev_err(>dev, "MAC0-associated PHY attached 2nd MACs MII 
bus not supported yet\n");
err = -ENODEV;
goto err_mdiobus_alloc;
-- 
2.1.4