Re: [PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Oliver Hartkopp
On 10.03.2013 14:05, Daniel Mack wrote: >>> @@ -817,8 +817,7 @@ static int can_notifier(struct notifier_block *nb, >>> unsigned long msg, >>> /* create new dev_rcv_lists for this device */ >>> d = kzalloc(sizeof(*d), GFP_KERNEL); >>> if (!d) { >>> -

Re: [PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Daniel Mack
On Sun, Mar 10, 2013 at 1:45 PM, Oliver Hartkopp wrote: > Hallo Valentin, > > thanks for the idea for the cleanup. > > But if you replace the the printk() statements it's worth to check if code > fits into a single line now, e.g. > > On 10.03.2013 13:28, Valentin Ilie wrote: > > r

Re: [PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Oliver Hartkopp
Hallo Valentin, thanks for the idea for the cleanup. But if you replace the the printk() statements it's worth to check if code fits into a single line now, e.g. On 10.03.2013 13:28, Valentin Ilie wrote: r = NULL; > @@ -749,7 +749,7 @@ int can_proto_register(const struct

[PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Valentin Ilie
Replace printk(KERN_ERR with pr_err Add space before { Signed-off-by: Valentin Ilie --- net/can/af_can.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/net/can/af_can.c b/net/can/af_can.c index c48e522..a14c0aa 100644 --- a/net/can/af_can.c +++

[PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Valentin Ilie
Replace printk(KERN_ERR with pr_err Add space before { Signed-off-by: Valentin Ilie valentin.i...@gmail.com --- net/can/af_can.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/net/can/af_can.c b/net/can/af_can.c index c48e522..a14c0aa 100644 ---

Re: [PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Oliver Hartkopp
Hallo Valentin, thanks for the idea for the cleanup. But if you replace the the printk() statements it's worth to check if code fits into a single line now, e.g. On 10.03.2013 13:28, Valentin Ilie wrote: r = NULL; @@ -749,7 +749,7 @@ int can_proto_register(const struct

Re: [PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Daniel Mack
On Sun, Mar 10, 2013 at 1:45 PM, Oliver Hartkopp socket...@hartkopp.net wrote: Hallo Valentin, thanks for the idea for the cleanup. But if you replace the the printk() statements it's worth to check if code fits into a single line now, e.g. On 10.03.2013 13:28, Valentin Ilie wrote:

Re: [PATCH] net: can: af_can.c: Fix checkpatch warnings

2013-03-10 Thread Oliver Hartkopp
On 10.03.2013 14:05, Daniel Mack wrote: @@ -817,8 +817,7 @@ static int can_notifier(struct notifier_block *nb, unsigned long msg, /* create new dev_rcv_lists for this device */ d = kzalloc(sizeof(*d), GFP_KERNEL); if (!d) { -