Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Jeroen Hofstee
Hello Tony, On 21-10-16 09:53, Tony Lindgren wrote: * Jeroen Hofstee [161021 00:37]: Hello Tony, On 21-10-16 08:38, Tony Lindgren wrote: * Jeroen Hofstee [161020 12:57]: Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Jeroen Hofstee
Hello Tony, On 21-10-16 09:53, Tony Lindgren wrote: * Jeroen Hofstee [161021 00:37]: Hello Tony, On 21-10-16 08:38, Tony Lindgren wrote: * Jeroen Hofstee [161020 12:57]: Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac id to common file") did not only move the

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161021 02:31]: > Aaah, lets wait a sec. I just saw there is another user of this function, > so above is simply not true > > if (of_machine_is_compatible("ti,dra7")) > return davinci_emac_3517_get_macid(dev, 0x514, slave, mac_addr);

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161021 02:31]: > Aaah, lets wait a sec. I just saw there is another user of this function, > so above is simply not true > > if (of_machine_is_compatible("ti,dra7")) > return davinci_emac_3517_get_macid(dev, 0x514, slave, mac_addr); Oh OK, then this will

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161021 00:37]: > Hello Tony, > > On 21-10-16 08:38, Tony Lindgren wrote: > > * Jeroen Hofstee [161020 12:57]: > > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > > > id to common file") did

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161021 00:37]: > Hello Tony, > > On 21-10-16 08:38, Tony Lindgren wrote: > > * Jeroen Hofstee [161020 12:57]: > > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > > > id to common file") did not only move the code for an am3517, it also > > > added

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Jeroen Hofstee
Hello Tony, On 21-10-16 08:38, Tony Lindgren wrote: * Jeroen Hofstee [161020 12:57]: Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac id to common file") did not only move the code for an am3517, it also added the slave parameter, resulting

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Jeroen Hofstee
Hello Tony, On 21-10-16 08:38, Tony Lindgren wrote: * Jeroen Hofstee [161020 12:57]: Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac id to common file") did not only move the code for an am3517, it also added the slave parameter, resulting in a invalid (all zero) mac

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161020 12:57]: > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") did not only move the code for an am3517, it also > added the slave parameter, resulting in a invalid (all zero) mac address > being

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161020 12:57]: > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") did not only move the code for an am3517, it also > added the slave parameter, resulting in a invalid (all zero) mac address > being returned. So change it back to