Re: [PATCH] net: dsa: fix led_classdev build errors
On Tue Jan 05 2021, Randy Dunlap wrote:
> Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y.
> This limits the latter to =m when LEDS_CLASS=m.
>
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function
> `hellcreek_ptp_setup':
> (.text+0xf80): undefined reference to `led_classdev_register_ext'
> microblaze-linux-ld: (.text+0xf94): undefined reference to
> `led_classdev_register_ext'
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function
> `hellcreek_ptp_free':
> (.text+0x1018): undefined reference to `led_classdev_unregister'
> microblaze-linux-ld: (.text+0x1024): undefined reference to
> `led_classdev_unregister'
>
> Signed-off-by: Randy Dunlap
> Reported-by: kernel test robot
> Link: lore.kernel.org/r/202101060655.iuvmjqs2-...@intel.com
> Cc: Kurt Kanzenbach
> Cc: net...@vger.kernel.org
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
Fixes: 7d9ee2e8ff15 ("net: dsa: hellcreek: Add PTP status LEDs")
Reviewed-by: Kurt Kanzenbach
Thanks,
Kurt
signature.asc
Description: PGP signature
Re: [PATCH] net: dsa: fix led_classdev build errors
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 5 Jan 2021 18:18:15 -0800 you wrote: > Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. > This limits the latter to =m when LEDS_CLASS=m. > > microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function > `hellcreek_ptp_setup': > (.text+0xf80): undefined reference to `led_classdev_register_ext' > microblaze-linux-ld: (.text+0xf94): undefined reference to > `led_classdev_register_ext' > microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function > `hellcreek_ptp_free': > (.text+0x1018): undefined reference to `led_classdev_unregister' > microblaze-linux-ld: (.text+0x1024): undefined reference to > `led_classdev_unregister' > > [...] Here is the summary with links: - net: dsa: fix led_classdev build errors https://git.kernel.org/netdev/net/c/7f847db30408 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
[PATCH] net: dsa: fix led_classdev build errors
Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. This limits the latter to =m when LEDS_CLASS=m. microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup': (.text+0xf80): undefined reference to `led_classdev_register_ext' microblaze-linux-ld: (.text+0xf94): undefined reference to `led_classdev_register_ext' microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_free': (.text+0x1018): undefined reference to `led_classdev_unregister' microblaze-linux-ld: (.text+0x1024): undefined reference to `led_classdev_unregister' Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: lore.kernel.org/r/202101060655.iuvmjqs2-...@intel.com Cc: Kurt Kanzenbach Cc: net...@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski --- drivers/net/dsa/hirschmann/Kconfig |1 + 1 file changed, 1 insertion(+) --- lnx-511-rc2.orig/drivers/net/dsa/hirschmann/Kconfig +++ lnx-511-rc2/drivers/net/dsa/hirschmann/Kconfig @@ -4,6 +4,7 @@ config NET_DSA_HIRSCHMANN_HELLCREEK depends on HAS_IOMEM depends on NET_DSA depends on PTP_1588_CLOCK + depends on LEDS_CLASS select NET_DSA_TAG_HELLCREEK help This driver adds support for Hirschmann Hellcreek TSN switches.
