Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-21 Thread Grygorii Strashko
On 07/20/2017 11:45 PM, Keerthy wrote: On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote: On 07/20/2017 05:28 PM, David Miller wrote: From: Grygorii Strashko Date: Thu, 20 Jul 2017 11:08:09 -0500 In general patch looks good to me, but it's really unexpected to receive IRQs while

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Keerthy
On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote: > > > On 07/20/2017 05:28 PM, David Miller wrote: >> From: Grygorii Strashko >> Date: Thu, 20 Jul 2017 11:08:09 -0500 >> >>> In general patch looks good to me, but it's really unexpected to >>> receive IRQs while CPSW is probing ;( >> >

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Grygorii Strashko
On 07/20/2017 05:28 PM, David Miller wrote: > From: Grygorii Strashko > Date: Thu, 20 Jul 2017 11:08:09 -0500 > >> In general patch looks good to me, but it's really unexpected to >> receive IRQs while CPSW is probing ;( > > This is a poor expectation. > > Boot loaders and other entities can

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread David Miller
From: Grygorii Strashko Date: Thu, 20 Jul 2017 11:08:09 -0500 > In general patch looks good to me, but it's really unexpected to > receive IRQs while CPSW is probing ;( This is a poor expectation. Boot loaders and other entities can leave the device in any state whatsoever. Furthermore, enabli

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Grygorii Strashko
On 07/20/2017 06:29 AM, Keerthy wrote: > Push the request_irq function to the end of probe so as > to ensure all the required fields are populated in the event > of an ISR getting executed right after requesting the irq. > > Currently while loading the crash kernel a crash was seen as > soon as

[PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Keerthy
Push the request_irq function to the end of probe so as to ensure all the required fields are populated in the event of an ISR getting executed right after requesting the irq. Currently while loading the crash kernel a crash was seen as soon as devm_request_threaded_irq was called. This was due to