Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 4:14 PM, Benjamin Herrenschmidt wrote: > On Tue, 2017-10-10 at 15:19 +1030, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or higher. > > Did you try

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 4:14 PM, Benjamin Herrenschmidt wrote: > On Tue, 2017-10-10 at 15:19 +1030, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or higher. > > Did you try "live" changing by either

Re: [PATCH] net: ftgmac100: Request clock and set speed

From: Joel Stanley Date: Tue, 10 Oct 2017 15:19:25 +1030 > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. > > Signed-off-by: Joel Stanley Hey Joel, it seems that Benjamin would like

Re: [PATCH] net: ftgmac100: Request clock and set speed

From: Joel Stanley Date: Tue, 10 Oct 2017 15:19:25 +1030 > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. > > Signed-off-by: Joel Stanley Hey Joel, it seems that Benjamin would like you to guard this new logic

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, 2017-10-10 at 15:19 +1030, Joel Stanley wrote: > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. Did you try "live" changing by either using ethtool or plugging into switches/hubs at different speed ? Also

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, 2017-10-10 at 15:19 +1030, Joel Stanley wrote: > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. Did you try "live" changing by either using ethtool or plugging into switches/hubs at different speed ? Also

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 2:34 PM, Florian Fainelli wrote: > > > On 10/09/2017 09:49 PM, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or higher. >> >> Signed-off-by: Joel Stanley

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 2:34 PM, Florian Fainelli wrote: > > > On 10/09/2017 09:49 PM, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or higher. >> >> Signed-off-by: Joel Stanley >> --- > >> @@ -161,6

Re: [PATCH] net: ftgmac100: Request clock and set speed

On 10/09/2017 09:49 PM, Joel Stanley wrote: > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. > > Signed-off-by: Joel Stanley > --- > @@ -161,6 +170,9 @@ static int

Re: [PATCH] net: ftgmac100: Request clock and set speed

On 10/09/2017 09:49 PM, Joel Stanley wrote: > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. > > Signed-off-by: Joel Stanley > --- > @@ -161,6 +170,9 @@ static int ftgmac100_reset_and_config_mac(struct >

[PATCH] net: ftgmac100: Request clock and set speed

According to the ASPEED datasheet, gigabit speeds require a clock of 100MHz or higher. Other speeds require 25MHz or higher. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[PATCH] net: ftgmac100: Request clock and set speed

According to the ASPEED datasheet, gigabit speeds require a clock of 100MHz or higher. Other speeds require 25MHz or higher. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 22 ++ 1 file changed, 22 insertions(+) diff --git