Re: [PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

On 2020/6/3 2:04, Cong Wang wrote: > On Mon, Jun 1, 2020 at 11:47 PM YueHaibing wrote: >> @@ -630,6 +625,9 @@ static int genl_family_rcv_msg_dumpit(const struct >> genl_family *family, >> err = __netlink_dump_start(net->genl_sock, skb, nlh, ); >> } >> >> +

Re: [PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

On Mon, Jun 1, 2020 at 11:47 PM YueHaibing wrote: > @@ -630,6 +625,9 @@ static int genl_family_rcv_msg_dumpit(const struct > genl_family *family, > err = __netlink_dump_start(net->genl_sock, skb, nlh, ); > } > > + genl_family_rcv_msg_attrs_free(info->family,

[PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

dumpit info is freed by cb->done now (genl_lock_done()/ genl_parallel_done()), however if any error occurs before cb->done is called, info and attrs will leak. unreferenced object 0x888119904840 (size 32): comm "syz-executor.0", pid 857, jiffies 4295306979 (age 18.692s) hex dump (first 32