Re: [PATCH] net: lio_core: remove redundant assignment to variable tx_done

2020-05-08 Thread Jakub Kicinski
On Fri,  8 May 2020 23:58:10 +0100 Colin King wrote:
> From: Colin Ian King 
> 
> The variable tx_done is being assigned with a value that is never read
> as the function returns a few statements later.  The assignment is
> redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King 

Applied, thank you!


[PATCH] net: lio_core: remove redundant assignment to variable tx_done

2020-05-08 Thread Colin King
From: Colin Ian King 

The variable tx_done is being assigned with a value that is never read
as the function returns a few statements later.  The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c 
b/drivers/net/ethernet/cavium/liquidio/lio_core.c
index d7e805749a5b..e40c64b79f66 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
@@ -782,7 +782,6 @@ static int liquidio_napi_poll(struct napi_struct *napi, int 
budget)
if ((work_done < budget && tx_done) ||
(iq && iq->pkt_in_done >= MAX_REG_CNT) ||
(droq->pkt_count >= MAX_REG_CNT)) {
-   tx_done = 1;
napi_complete_done(napi, work_done);
 
octeon_enable_irq(droq->oct_dev, droq->q_no);
-- 
2.25.1