Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-27 Thread Gustavo A. R. Silva
Quoting David Miller : From: Willem de Bruijn Date: Sat, 25 Nov 2017 16:15:01 -0500 On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva wrote: gso_type is being used in binary AND operations together with

Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-27 Thread Gustavo A. R. Silva
Quoting David Miller : From: Willem de Bruijn Date: Sat, 25 Nov 2017 16:15:01 -0500 On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva wrote: gso_type is being used in binary AND operations together with SKB_GSO_UDP. The issue is that variable gso_type is of type unsigned short and

Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-26 Thread David Miller
From: Willem de Bruijn Date: Sat, 25 Nov 2017 16:15:01 -0500 > On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva > wrote: >> gso_type is being used in binary AND operations together with SKB_GSO_UDP. >> The issue is that variable

Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-26 Thread David Miller
From: Willem de Bruijn Date: Sat, 25 Nov 2017 16:15:01 -0500 > On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva > wrote: >> gso_type is being used in binary AND operations together with SKB_GSO_UDP. >> The issue is that variable gso_type is of type unsigned short and >> SKB_GSO_UDP expands

Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-25 Thread Willem de Bruijn
On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva wrote: > gso_type is being used in binary AND operations together with SKB_GSO_UDP. > The issue is that variable gso_type is of type unsigned short and > SKB_GSO_UDP expands to more than 16 bits: > > SKB_GSO_UDP = 1 <<

Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-25 Thread Willem de Bruijn
On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva wrote: > gso_type is being used in binary AND operations together with SKB_GSO_UDP. > The issue is that variable gso_type is of type unsigned short and > SKB_GSO_UDP expands to more than 16 bits: > > SKB_GSO_UDP = 1 << 16 > > this makes any

[PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-25 Thread Gustavo A. R. Silva
gso_type is being used in binary AND operations together with SKB_GSO_UDP. The issue is that variable gso_type is of type unsigned short and SKB_GSO_UDP expands to more than 16 bits: SKB_GSO_UDP = 1 << 16 this makes any binary AND operation between gso_type and SKB_GSO_UDP to be always zero,

[PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-25 Thread Gustavo A. R. Silva
gso_type is being used in binary AND operations together with SKB_GSO_UDP. The issue is that variable gso_type is of type unsigned short and SKB_GSO_UDP expands to more than 16 bits: SKB_GSO_UDP = 1 << 16 this makes any binary AND operation between gso_type and SKB_GSO_UDP to be always zero,