Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Andrew Lunn
> > +Required properties: > > + - reg - The ID number for the phy, usually a small integer > > Isn't this the MDIO bus address? Hi Rob Yes. This text has been take direct from the generic PHY binding. > This should have a compatible string too. Please see

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Andrew Lunn
> > +Required properties: > > + - reg - The ID number for the phy, usually a small integer > > Isn't this the MDIO bus address? Hi Rob Yes. This text has been take direct from the generic PHY binding. > This should have a compatible string too. Please see

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Florian Fainelli
On 04/19/2018 01:28 AM, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for this device.

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Florian Fainelli
On 04/19/2018 01:28 AM, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for this device. I would not think this

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Rob Herring
On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-24 Thread Rob Herring
On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for this device. > >

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-20 Thread Måns Andersson
On Thu, Apr 19, 2018 at 02:24:27PM +0200, Miguel Ojeda wrote: > On Thu, Apr 19, 2018 at 10:28 AM, Måns Andersson > wrote: > > From: Mans Andersson > > > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > > > Hi Mans, > >

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-20 Thread Måns Andersson
On Thu, Apr 19, 2018 at 02:24:27PM +0200, Miguel Ojeda wrote: > On Thu, Apr 19, 2018 at 10:28 AM, Måns Andersson > wrote: > > From: Mans Andersson > > > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > > > Hi Mans, > > Some quick notes. > > > In addition the TLK10X

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-20 Thread Måns Andersson
On Thu, Apr 19, 2018 at 02:09:02PM +0200, Andrew Lunn wrote: > On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > > From: Mans Andersson > > > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > > > In addition the TLK10X needs to be

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-20 Thread Måns Andersson
On Thu, Apr 19, 2018 at 02:09:02PM +0200, Andrew Lunn wrote: > On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > > From: Mans Andersson > > > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > > > In addition the TLK10X needs to be removed from DP83848

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-19 Thread Miguel Ojeda
On Thu, Apr 19, 2018 at 10:28 AM, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > Hi Mans, Some quick notes. > In addition the TLK10X needs to be removed from DP83848 driver as

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-19 Thread Miguel Ojeda
On Thu, Apr 19, 2018 at 10:28 AM, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > Hi Mans, Some quick notes. > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-19 Thread Andrew Lunn
On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here

Re: [PATCH] net: phy: TLK10X initial driver submission

2018-04-19 Thread Andrew Lunn
On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for this device. > >

[PATCH] net: phy: TLK10X initial driver submission

2018-04-19 Thread Måns Andersson
From: Mans Andersson Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. In addition the TLK10X needs to be removed from DP83848 driver as the power back off support is added here for this device. Datasheet: http://www.ti.com/lit/gpn/tlk106 ---

[PATCH] net: phy: TLK10X initial driver submission

2018-04-19 Thread Måns Andersson
From: Mans Andersson Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. In addition the TLK10X needs to be removed from DP83848 driver as the power back off support is added here for this device. Datasheet: http://www.ti.com/lit/gpn/tlk106 ---