Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-30 Thread Andrew Lunn
> > diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c > > index ed8a67d..5d3d138 100644 > > --- a/drivers/net/phy/marvell.c > > +++ b/drivers/net/phy/marvell.c > > @@ -55,6 +55,7 @@ > > > >  #define MII_M1011_IEVENT   0x13 > >  #define MII_M1011_IEVENT_CLEAR

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-27 Thread Jisheng Zhang
On Thu, 26 Apr 2018 12:39:59 +0530 Bhadram Varka wrote: > > > > diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c > > index c22e8e383247..b6abe1cbc84b 100644 > > --- a/drivers/net/phy/marvell.c > > +++ b/drivers/net/phy/marvell.c > > @@ -115,6 +115,9 @@ > >

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-27 Thread Jisheng Zhang
On Fri, 27 Apr 2018 09:22:34 +0530 Bhadram Varka wrote: > Hi Andrew/Jisheng, > > On 4/26/2018 6:10 PM, Andrew Lunn wrote: > >> hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel > >> requires WOL should be "stick". > > I see two different cases: > > > > Suspend/resume: The WoL

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-26 Thread Bhadram Varka
Hi Andrew/Jisheng, On 4/26/2018 6:10 PM, Andrew Lunn wrote: hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel requires WOL should be "stick". I see two different cases: Suspend/resume: The WoL state in the kernel is probably kept across such a cycle. If so, you would expect

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-26 Thread Andrew Lunn
> hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel > requires WOL should be "stick". I see two different cases: Suspend/resume: The WoL state in the kernel is probably kept across such a cycle. If so, you would expect another suspend/resume to also work, without needs to recon

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-26 Thread Jisheng Zhang
On Thu, 26 Apr 2018 11:56:33 +0530 Bhadram Varka wrote: > Hi, > On 4/26/2018 11:45 AM, Jisheng Zhang wrote: > > Hi, > > > > On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: > > > >> Hi, > >> > >> On 4/19/2018 5:48 PM, Andrew Lunn wrote: > >>> On Thu, Apr 19, 2018 at 04:02:32PM +0800, J

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-26 Thread Bhadram Varka
Hi, On 4/26/2018 11:56 AM, Bhadram Varka wrote: Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-25 Thread Bhadram Varka
Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin wil

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-25 Thread Jisheng Zhang
Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: > Hi, > > On 4/19/2018 5:48 PM, Andrew Lunn wrote: > > On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: > >> From: Jingju Hou > >> > >> If WOL event happened once, the LED[2] interrupt pin will not be > >> cleared unles

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-25 Thread Bhadram Varka
Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin will not be cleared unless reading the CSISR register. So clear the WOL event before enabling it. Signed-off-by: J

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Andrew Lunn
On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: > From: Jingju Hou > > If WOL event happened once, the LED[2] interrupt pin will not be > cleared unless reading the CSISR register. So clear the WOL event > before enabling it. > > Signed-off-by: Jingju Hou > Signed-off-by: Jisheng

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Andrew Lunn
> >IIRC, the phy irq isn't necessary for WOL. The phy interrupt pin isn't > >necessarily taken as "interrupt" > Please correct me if I am wrong. In this case how the system will wake up > from the SC7.There has to be wake capable irq/gpio pin to do this operation. > Hi Bhadram I've seem implement

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Bhadram Varka
...@vger.kernel.org; linux- ker...@vger.kernel.org; Jingju Hou Subject: Re: [PATCH] net: phy: marvell: clear wol event before setting it Hi, On Thu, 19 Apr 2018 08:38:45 + Bhadram Varka wrote: Hi, -Original Message- From: netdev-ow...@vger.kernel.org On Behalf Of Jisheng Zhang Sent

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Jisheng Zhang
r ; net...@vger.kernel.org; linux- > > ker...@vger.kernel.org; Jingju Hou > > Subject: Re: [PATCH] net: phy: marvell: clear wol event before setting it > > > > Hi, > > > > On Thu, 19 Apr 2018 08:38:45 + Bhadram Varka wrote: > > > > >

RE: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Bhadram Varka
g > > > Sent: Thursday, April 19, 2018 1:33 PM > > > To: Andrew Lunn ; Florian Fainelli > > > ; David S. Miller > > > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jingju Hou > > > > > > Subject: [PATCH] net: phy: marvell: clear wol even

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Jisheng Zhang
i ; > > David S. Miller > > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jingju Hou > > > > Subject: [PATCH] net: phy: marvell: clear wol event before setting it > > > > From: Jingju Hou > > > > If WOL event happened once, the LED[2] interr

RE: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Bhadram Varka
> Subject: [PATCH] net: phy: marvell: clear wol event before setting it > > From: Jingju Hou > > If WOL event happened once, the LED[2] interrupt pin will not be cleared > unless > reading the CSISR register. So clear the WOL event before enabling it. > > Signed

[PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Jisheng Zhang
From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin will not be cleared unless reading the CSISR register. So clear the WOL event before enabling it. Signed-off-by: Jingju Hou Signed-off-by: Jisheng Zhang --- drivers/net/phy/marvell.c | 9 + 1 file changed, 9 inserti