Re: [PATCH] net: rtw88: fix an issue about leak system resources
On Tue, May 5, 2020 at 3:59 AM Dejin Zheng wrote: > On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote: > > (Markus is clearly not taking the hint, but FYI for everyone else:) > Brian, Thanks very much for your reminder, These comments have always > bothered me. Now I can put it on my blacklist. Thank you very very much! Perhaps we need to find a good researcher student who may do a MD dissertation out of the case :-) -- With Best Regards, Andy Shevchenko
Re: [PATCH] net: rtw88: fix an issue about leak system resources
On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote: > (Markus is clearly not taking the hint, but FYI for everyone else:) > > On Mon, May 4, 2020 at 8:00 AM Markus Elfring wrote: > > > BTW, In the past week, you asked me to change the commit comments in my > > > 6 patches like this one. Let me return to the essence of patch, point > > > out the code problems and better solutions will be more popular. > > > > I would appreciate if various update suggestions would become nicer somehow. > > Markus is not really providing any value to the community. Just search > for his recent mail history -- it's all silly commit message > nitpicking of little value. He's been blacklisted by a number of > people already: > > https://lkml.kernel.org/lkml/20190919112937.ga3072...@kroah.com/ > > Some people continue to humor him, but it's mostly just a waste of > their time, as this has been going on for years. Just look at searches > like this, and tell me whether they produce anything useful: > > https://lkml.kernel.org/lkml/?q=%22markus+elfring%22=5000 > Brian, Thanks very much for your reminder, These comments have always bothered me. Now I can put it on my blacklist. Thank you very very much! BR, Dejin > Brian
Re: [PATCH] net: rtw88: fix an issue about leak system resources
(Markus is clearly not taking the hint, but FYI for everyone else:) On Mon, May 4, 2020 at 8:00 AM Markus Elfring wrote: > > BTW, In the past week, you asked me to change the commit comments in my > > 6 patches like this one. Let me return to the essence of patch, point > > out the code problems and better solutions will be more popular. > > I would appreciate if various update suggestions would become nicer somehow. Markus is not really providing any value to the community. Just search for his recent mail history -- it's all silly commit message nitpicking of little value. He's been blacklisted by a number of people already: https://lkml.kernel.org/lkml/20190919112937.ga3072...@kroah.com/ Some people continue to humor him, but it's mostly just a waste of their time, as this has been going on for years. Just look at searches like this, and tell me whether they produce anything useful: https://lkml.kernel.org/lkml/?q=%22markus+elfring%22=5000 Brian
Re: [PATCH] net: rtw88: fix an issue about leak system resources
>>> the related system resources were not released when pci_iomap() return >>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to >>> fix it. >> >> How do you think about a wording variant like the following? >> >>Subject: >>[PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping() >> >>Change description: >>A call of the function “pci_request_regions” can fail here. >>The corresponding system resources were not released then. >>Thus add a call of the function “pci_release_regions”. >> >> > Markus, I think my commit comments is a sufficiently clear description > for this patch. I got an other impression for specific aspects. > Someone has told me not to send commit comments again and again > when it is enough clear. My patch review tries should give you hints where I noticed wording weaknesses. The corresponding change tolerance can vary by involved contributors. > Because it only wastes the precious time of the maintainer > and very very little help for patch improvement. I hope that also your commit messages will improve. > BTW, In the past week, you asked me to change the commit comments in my > 6 patches like this one. Let me return to the essence of patch, point > out the code problems and better solutions will be more popular. I would appreciate if various update suggestions would become nicer somehow. Regards, Markus
Re: [PATCH] net: rtw88: fix an issue about leak system resources
> the related system resources were not released when pci_iomap() return > error in the rtw_pci_io_mapping() function. add pci_release_regions() to > fix it. How do you think about a wording variant like the following? Subject: [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping() Change description: A call of the function “pci_request_regions” can fail here. The corresponding system resources were not released then. Thus add a call of the function “pci_release_regions”. Regards, Markus
