RE: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-05 Thread Gomes, Vinicius
Hi Vladimir, > Looks ok to me, but I have no saying over ethtool API. Actually I don't even > know whom to ask - the output of ./scripts/get_maintainer.pl > net/core/ethtool.c is a bit overwhelming. > To avoid conflicts, there needs to be somebody out of us who takes Eric's > simplification, with

Re: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-05 Thread Vladimir Oltean
Hi Vinicius, On Wed, 4 Sep 2019 at 00:26, Vinicius Costa Gomes wrote: > > Hi, > > Vladimir Oltean writes: > > > Right. And while we're at it, there's still the potential > > division-by-zero problem which I still don't know how to solve without > > implementing a full-blown

Re: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-03 Thread Vinicius Costa Gomes
Hi, Vladimir Oltean writes: > Right. And while we're at it, there's still the potential > division-by-zero problem which I still don't know how to solve without > implementing a full-blown __ethtool_get_link_ksettings parser that > checks against all the possible outputs it can have under the

Re: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-03 Thread Vladimir Oltean
On Tue, 3 Sep 2019 at 10:19, Eric Dumazet wrote: > > > > On 9/3/19 3:08 AM, Gustavo A. R. Silva wrote: > > Add suffix LL to constant 1000 in order to avoid a potential integer > > overflow and give the compiler complete information about the proper > > arithmetic to use. Notice that this constant

Re: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-03 Thread Eric Dumazet
On 9/3/19 3:08 AM, Gustavo A. R. Silva wrote: > Add suffix LL to constant 1000 in order to avoid a potential integer > overflow and give the compiler complete information about the proper > arithmetic to use. Notice that this constant is being used in a context > that expects an expression of

Re: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-02 Thread Vladimir Oltean
On Tue, 3 Sep 2019 at 04:08, Gustavo A. R. Silva wrote: > > Add suffix LL to constant 1000 in order to avoid a potential integer > overflow and give the compiler complete information about the proper > arithmetic to use. Notice that this constant is being used in a context > that expects an

[PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

2019-09-02 Thread Gustavo A. R. Silva
Add suffix LL to constant 1000 in order to avoid a potential integer overflow and give the compiler complete information about the proper arithmetic to use. Notice that this constant is being used in a context that expects an expression of type s64, but it's currently evaluated using 32-bit