Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-24 Thread David Miller
From: Petko Manolov Date: Fri, 19 Apr 2013 11:21:49 +0300 (EEST) > From: Petko Manolov > > (For inclusion in 3.10, diff against latest net-next.) > > Pegasus driver used single callback for sync and async control URBs. > Special flags were employed to distinguish between both, but due to

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-24 Thread David Miller
From: Petko Manolov pet...@nucleusys.com Date: Fri, 19 Apr 2013 11:21:49 +0300 (EEST) From: Petko Manolov pet...@nucleusys.com (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-19 Thread Petko Manolov
From: Petko Manolov (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic (as Sarah Sharp spotted) it didn't always work. As a result of this

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-19 Thread Petko Manolov
From: Petko Manolov pet...@nucleusys.com (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic (as Sarah Sharp spotted) it didn't always work.

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-15 Thread Petko Manolov
On Fri, 12 Apr 2013, David Miller wrote: When submitting a new version of a patch, you must list what changed from the previous version after the "---" delimiter rather than having people try and guess. Got it. However, i've already spammed you, Sarah and two major mailing lists so i

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-15 Thread Petko Manolov
On Fri, 12 Apr 2013, David Miller wrote: When submitting a new version of a patch, you must list what changed from the previous version after the --- delimiter rather than having people try and guess. Got it. However, i've already spammed you, Sarah and two major mailing lists so i assume

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-12 Thread David Miller
From: Petko Manolov Date: Thu, 11 Apr 2013 22:00:59 +0300 (EEST) > From: Petko Manolov > > (For inclusion in 3.10, diff against latest net-next.) > > Pegasus driver used single callback for sync and async control URBs. > Special flags were employed to distinguish between both, but due to

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-12 Thread David Miller
From: Petko Manolov pet...@nucleusys.com Date: Thu, 11 Apr 2013 22:00:59 +0300 (EEST) From: Petko Manolov pet...@nucleusys.com (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Petko Manolov
From: Petko Manolov (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic (as Sarah Sharp spotted) it didn't always work. As a result of this

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Petko Manolov
On Thu, 11 Apr 2013, Dan Williams wrote: > On Thu, 2013-04-11 at 10:09 +0300, Petko Manolov wrote: > > From: Petko Manolov > > > > (For inclusion in 3.10, diff against latest net-next.) > > Your mail client replaced tabs with spaces. Make sure when adding the > patch to the mail, you choose

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Dan Williams
On Thu, 2013-04-11 at 10:09 +0300, Petko Manolov wrote: > From: Petko Manolov > > (For inclusion in 3.10, diff against latest net-next.) Your mail client replaced tabs with spaces. Make sure when adding the patch to the mail, you choose the "preformatted" option or whatever the client has to

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Petko Manolov
From: Petko Manolov (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic (as Sarah Sharp spotted) it didn't always work. As a result of

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Petko Manolov
From: Petko Manolov pet...@nucleusys.com (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic (as Sarah Sharp spotted) it didn't always work.

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Dan Williams
On Thu, 2013-04-11 at 10:09 +0300, Petko Manolov wrote: From: Petko Manolov pet...@nucleusys.com (For inclusion in 3.10, diff against latest net-next.) Your mail client replaced tabs with spaces. Make sure when adding the patch to the mail, you choose the preformatted option or whatever the

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Petko Manolov
On Thu, 11 Apr 2013, Dan Williams wrote: On Thu, 2013-04-11 at 10:09 +0300, Petko Manolov wrote: From: Petko Manolov pet...@nucleusys.com (For inclusion in 3.10, diff against latest net-next.) Your mail client replaced tabs with spaces. Make sure when adding the patch to the mail,

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-11 Thread Petko Manolov
From: Petko Manolov pet...@nucleusys.com (For inclusion in 3.10, diff against latest net-next.) Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic (as Sarah Sharp spotted) it didn't always work.

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-10 Thread David Miller
I think you need to read Documentation/SubmittingPatches, and Documentation/email-clients.txt Do not submit the diff for the individual files seperately, provide all the changes together as a single patch. Do not use an attachment, instead provide your patch inline as plain ASCII, unformatted

[PATCH] net: usb: active URB submitted multiple times

2013-04-10 Thread Petko Manolov
From: Petko Manolov Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic it didn't always work. Now [get|set]_registers() are much simpler. Async write is also leaner and does not use single,

[PATCH] net: usb: active URB submitted multiple times

2013-04-10 Thread Petko Manolov
From: Petko Manolov pet...@nucleusys.com Pegasus driver used single callback for sync and async control URBs. Special flags were employed to distinguish between both, but due to flawed logic it didn't always work. Now [get|set]_registers() are much simpler. Async write is also leaner and

Re: [PATCH] net: usb: active URB submitted multiple times

2013-04-10 Thread David Miller
I think you need to read Documentation/SubmittingPatches, and Documentation/email-clients.txt Do not submit the diff for the individual files seperately, provide all the changes together as a single patch. Do not use an attachment, instead provide your patch inline as plain ASCII, unformatted