Re: [PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

(Please do not top-post.) On Sunday 08 June 2014 22:47:31 Rickard Strandqvist wrote: > I found this error in some of the files. And after discussion with > Larry Finger and Peter Wu, it was decided that all files with this if > statement should change. > > But of course I should update the

Re: [PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

Hi Quite right! I found this error in some of the files. And after discussion with Larry Finger and Peter Wu, it was decided that all files with this if statement should change. But of course I should update the comment to something more suitable. Kind regards Rickard Strandqvist 2014-06-08

Re: [PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

On Sun, 8 Jun 2014, Rickard Strandqvist wrote: > I find a logical error in an if statement '(X & 0xfc) == 0x3' is always false > Where is the 0xfc that your converting? > After pointing this out, Larry Finger informed what would be the correct one. > '(X & 0x3) == 0x3' > This is already what

Re: [PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

On Sun, 8 Jun 2014, Rickard Strandqvist wrote: I find a logical error in an if statement '(X 0xfc) == 0x3' is always false Where is the 0xfc that your converting? After pointing this out, Larry Finger informed what would be the correct one. '(X 0x3) == 0x3' This is already what it is,

Re: [PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

Hi Quite right! I found this error in some of the files. And after discussion with Larry Finger and Peter Wu, it was decided that all files with this if statement should change. But of course I should update the comment to something more suitable. Kind regards Rickard Strandqvist 2014-06-08

Re: [PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

(Please do not top-post.) On Sunday 08 June 2014 22:47:31 Rickard Strandqvist wrote: I found this error in some of the files. And after discussion with Larry Finger and Peter Wu, it was decided that all files with this if statement should change. But of course I should update the comment to

[PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

I find a logical error in an if statement '(X & 0xfc) == 0x3' is always false After pointing this out, Larry Finger informed what would be the correct one. '(X & 0x3) == 0x3' Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/rtlwifi/rtl8723be/hw.c |2 +- 1 file changed, 1

[PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false

I find a logical error in an if statement '(X 0xfc) == 0x3' is always false After pointing this out, Larry Finger informed what would be the correct one. '(X 0x3) == 0x3' Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/net/wireless/rtlwifi/rtl8723be/hw.c