Re: [PATCH] net: x86: bpf: don't forget to free sk_filter (v2)

2013-11-07 Thread David Miller
From: Andrey Vagin Date: Thu, 7 Nov 2013 08:35:12 +0400 > sk_filter isn't freed if bpf_func is equal to sk_run_filter. > > This memory leak was introduced by v3.12-rc3-224-gd45ed4a4 > "net: fix unsafe set_memory_rw from softirq". > > Before this patch sk_filter was freed in

Re: [PATCH] net: x86: bpf: don't forget to free sk_filter (v2)

2013-11-07 Thread Alexei Starovoitov
On Wed, Nov 6, 2013 at 8:35 PM, Andrey Vagin wrote: > sk_filter isn't freed if bpf_func is equal to sk_run_filter. > > This memory leak was introduced by v3.12-rc3-224-gd45ed4a4 > "net: fix unsafe set_memory_rw from softirq". > > Before this patch sk_filter was freed in sk_filter_release_rcu, >

Re: [PATCH] net: x86: bpf: don't forget to free sk_filter (v2)

2013-11-07 Thread Alexei Starovoitov
On Wed, Nov 6, 2013 at 8:35 PM, Andrey Vagin ava...@openvz.org wrote: sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by v3.12-rc3-224-gd45ed4a4 net: fix unsafe set_memory_rw from softirq. Before this patch sk_filter was freed in

Re: [PATCH] net: x86: bpf: don't forget to free sk_filter (v2)

2013-11-07 Thread David Miller
From: Andrey Vagin ava...@openvz.org Date: Thu, 7 Nov 2013 08:35:12 +0400 sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by v3.12-rc3-224-gd45ed4a4 net: fix unsafe set_memory_rw from softirq. Before this patch sk_filter was freed in

[PATCH] net: x86: bpf: don't forget to free sk_filter (v2)

2013-11-06 Thread Andrey Vagin
sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by v3.12-rc3-224-gd45ed4a4 "net: fix unsafe set_memory_rw from softirq". Before this patch sk_filter was freed in sk_filter_release_rcu, now it should be freed in bpf_jit_free. Here is output of

[PATCH] net: x86: bpf: don't forget to free sk_filter (v2)

2013-11-06 Thread Andrey Vagin
sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by v3.12-rc3-224-gd45ed4a4 net: fix unsafe set_memory_rw from softirq. Before this patch sk_filter was freed in sk_filter_release_rcu, now it should be freed in bpf_jit_free. Here is output of kmemleak: