Re: [PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Joe Perches
On Fri, 2013-04-05 at 18:39 +0200, Paul Bolle wrote: > On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: > > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > > > pr_debug/dev_dbg/nfc_dev_dbg logging messages > > depend on this. > >

Re: [PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > pr_debug/dev_dbg/nfc_dev_dbg logging messages > depend on this. Thanks. But then a NFC_DEBUG symbol needs to be added, because now the

Re: [PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Joe Perches
On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be > any nfc code that uses a DEBUG macro. This line can safely be removed. [] > diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile [] > -ccflags-$(CONFIG_NFC_DEBUG) :=

[PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be any nfc code that uses a DEBUG macro. This line can safely be removed. Signed-off-by: Paul Bolle --- Untested. drivers/nfc/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nfc/Makefile

[PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be any nfc code that uses a DEBUG macro. This line can safely be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. drivers/nfc/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nfc/Makefile

Re: [PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Joe Perches
On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be any nfc code that uses a DEBUG macro. This line can safely be removed. [] diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile [] -ccflags-$(CONFIG_NFC_DEBUG) :=

Re: [PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. Thanks. But then a NFC_DEBUG symbol needs to be added, because now the DEBUG

Re: [PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Joe Perches
On Fri, 2013-04-05 at 18:39 +0200, Paul Bolle wrote: On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. Thanks. But then a