Re: [PATCH] nfc: fix get_unaligned_...() misuses

2017-04-16 Thread Samuel Ortiz
On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote: > On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote: > > * use unaligned.h, not unaligned/access_ok.h > > ... which got misspelled in that patch, sorry... Fixed variant follows: > > commit b3e79ba1708c9b74781079c9f8617448fce36b51 > A

Re: [PATCH] nfc: fix get_unaligned_...() misuses

2017-04-07 Thread kbuild test robot
Hi Al, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc5 next-20170406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Al-Viro/nfc-fix-get_unaligned_-misuses/20170407-1

Re: [PATCH] nfc: fix get_unaligned_...() misuses

2017-04-07 Thread kbuild test robot
Hi Al, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc5 next-20170406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Al-Viro/nfc-fix-get_unaligned_-misuses/20170407-1

Re: [PATCH] nfc: fix get_unaligned_...() misuses

2017-04-06 Thread Al Viro
On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote: > * use unaligned.h, not unaligned/access_ok.h ... which got misspelled in that patch, sorry... Fixed variant follows: commit b3e79ba1708c9b74781079c9f8617448fce36b51 Author: Al Viro Date: Thu Apr 6 12:42:14 2017 -0400 nfc: fix get

[PATCH] nfc: fix get_unaligned_...() misuses

2017-04-06 Thread Al Viro
* use unaligned.h, not unaligned/access_ok.h * if a local variable of type uint16_t is unaligned, your compiler is FUBAR * the whole point of get_unaligned_... is to avoid memcpy + ..._to_cpu(). Using it *after* memcpy() (into aligned object, no less) is pointless. Signed-off-by: Al Viro dif