Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-21 Thread Alexander Gordeev
On Mon, Jan 20, 2014 at 03:48:56PM -0700, Keith Busch wrote: > On Mon, 20 Jan 2014, Alexander Gordeev wrote: > >This is an attempt to make handling of admin queue in a > >single scope. This update also fixes a IRQ leak in case > >nvme_setup_io_queues() failed to allocate enough iomem > >and bailed

Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-21 Thread Alexander Gordeev
On Mon, Jan 20, 2014 at 03:48:56PM -0700, Keith Busch wrote: On Mon, 20 Jan 2014, Alexander Gordeev wrote: This is an attempt to make handling of admin queue in a single scope. This update also fixes a IRQ leak in case nvme_setup_io_queues() failed to allocate enough iomem and bailed out with

Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-20 Thread Keith Busch
On Mon, 20 Jan 2014, Alexander Gordeev wrote: This is an attempt to make handling of admin queue in a single scope. This update also fixes a IRQ leak in case nvme_setup_io_queues() failed to allocate enough iomem and bailed out with -ENOMEM errno. This definitely seems to improve the code

Re: [PATCH] nvme: Cleanup nvme_dev_start()

2014-01-20 Thread Keith Busch
On Mon, 20 Jan 2014, Alexander Gordeev wrote: This update fixes an oddity when a device is first added and then removed from dev_list in case of initialization failure, instead of just being added in case of success. Signed-off-by: Alexander Gordeev --- drivers/block/nvme-core.c | 19

[PATCH] nvme: Cleanup nvme_dev_start()

2014-01-20 Thread Alexander Gordeev
This update fixes an oddity when a device is first added and then removed from dev_list in case of initialization failure, instead of just being added in case of success. Signed-off-by: Alexander Gordeev --- drivers/block/nvme-core.c | 19 --- 1 files changed, 8 insertions(+),

[PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-20 Thread Alexander Gordeev
This is an attempt to make handling of admin queue in a single scope. This update also fixes a IRQ leak in case nvme_setup_io_queues() failed to allocate enough iomem and bailed out with -ENOMEM errno. Signed-off-by: Alexander Gordeev --- drivers/block/nvme-core.c | 44

Re: [PATCH] nvme: Cleanup nvme_dev_start()

2014-01-20 Thread Keith Busch
On Mon, 20 Jan 2014, Alexander Gordeev wrote: This update fixes an oddity when a device is first added and then removed from dev_list in case of initialization failure, instead of just being added in case of success. Signed-off-by: Alexander Gordeev agord...@redhat.com ---

Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-20 Thread Keith Busch
On Mon, 20 Jan 2014, Alexander Gordeev wrote: This is an attempt to make handling of admin queue in a single scope. This update also fixes a IRQ leak in case nvme_setup_io_queues() failed to allocate enough iomem and bailed out with -ENOMEM errno. This definitely seems to improve the code

[PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-20 Thread Alexander Gordeev
This is an attempt to make handling of admin queue in a single scope. This update also fixes a IRQ leak in case nvme_setup_io_queues() failed to allocate enough iomem and bailed out with -ENOMEM errno. Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/block/nvme-core.c | 44

[PATCH] nvme: Cleanup nvme_dev_start()

2014-01-20 Thread Alexander Gordeev
This update fixes an oddity when a device is first added and then removed from dev_list in case of initialization failure, instead of just being added in case of success. Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/block/nvme-core.c | 19 --- 1 files