Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

On Wed, Apr 18, 2018 at 08:45:25AM -0600, Keith Busch wrote: > Nothing against this patch. This just doesn't look correct even from > before since nvme_find_path can set head->current_path right back to > this namespace that we're trying to clear. > > Christoph, am I missing something here or

Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

On Wed, Apr 18, 2018 at 08:45:25AM -0600, Keith Busch wrote: > Nothing against this patch. This just doesn't look correct even from > before since nvme_find_path can set head->current_path right back to > this namespace that we're trying to clear. > > Christoph, am I missing something here or

Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

On Wed, Apr 18, 2018 at 03:32:47PM +0800, Jianchao Wang wrote: > With lockdep enabled, when trigger nvme_remove, suspicious RCU > usage warning will be printed out. > Fix it with adding srcu_read_lock/unlock in it. > > Signed-off-by: Jianchao Wang > --- >

Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

On Wed, Apr 18, 2018 at 03:32:47PM +0800, Jianchao Wang wrote: > With lockdep enabled, when trigger nvme_remove, suspicious RCU > usage warning will be printed out. > Fix it with adding srcu_read_lock/unlock in it. > > Signed-off-by: Jianchao Wang > --- > drivers/nvme/host/nvme.h | 9 +++--

Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

On Wed, Apr 18, 2018 at 03:32:47PM +0800, Jianchao Wang wrote: > With lockdep enabled, when trigger nvme_remove, suspicious RCU > usage warning will be printed out. > Fix it with adding srcu_read_lock/unlock in it. Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

On Wed, Apr 18, 2018 at 03:32:47PM +0800, Jianchao Wang wrote: > With lockdep enabled, when trigger nvme_remove, suspicious RCU > usage warning will be printed out. > Fix it with adding srcu_read_lock/unlock in it. Looks fine, Reviewed-by: Christoph Hellwig

[PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

With lockdep enabled, when trigger nvme_remove, suspicious RCU usage warning will be printed out. Fix it with adding srcu_read_lock/unlock in it. Signed-off-by: Jianchao Wang --- drivers/nvme/host/nvme.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)

[PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path

With lockdep enabled, when trigger nvme_remove, suspicious RCU usage warning will be printed out. Fix it with adding srcu_read_lock/unlock in it. Signed-off-by: Jianchao Wang --- drivers/nvme/host/nvme.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git