Re: [PATCH] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero

Hi Axel, Thanks for the patch Acked-by: Srinivas Kandagatla I remember fixing this sometime back which was reported by static checker reported by Dan Carpenter, I forgot to send it over to wider audience. Thanks for reminding. --srini On 18/09/15 10:50, Axel Lin wrote: It's pointless to

[PATCH] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero

It's pointless to test (cell->bit_offset || cell->bit_offset). nvmem_shift_read_buffer_in_place() should be called when (cell->bit_offset || cell->nbits). Signed-off-by: Axel Lin --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c

[PATCH] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero

It's pointless to test (cell->bit_offset || cell->bit_offset). nvmem_shift_read_buffer_in_place() should be called when (cell->bit_offset || cell->nbits). Signed-off-by: Axel Lin --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero

Hi Axel, Thanks for the patch Acked-by: Srinivas Kandagatla I remember fixing this sometime back which was reported by static checker reported by Dan Carpenter, I forgot to send it over to wider audience. Thanks for reminding. --srini On 18/09/15 10:50,