Re: [PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level

2018-05-11 Thread Andrew Morton
On Fri, 11 May 2018 12:16:51 +0800 Larry Chen wrote: > > Nice changelog, but it gives no information about the severity of the > > bug: how often does it hit and what is the end-user impact. > > > > This info is needed so that I and others can decide which kernel > > version(s) need the patch, so

Re: [PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level

2018-05-10 Thread Larry Chen
Hello Andrew, On 05/11/2018 05:49 AM, Andrew Morton wrote: On Thu, 10 May 2018 13:32:30 +0800 Larry Chen wrote: ocfs2_inode_lock_tracker as a variant of ocfs2_inode_lock, is used to prevent deadlock due to recursive lock acquisition. But this function does not distinguish whether the reques

Re: [PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level

2018-05-10 Thread Andrew Morton
On Thu, 10 May 2018 13:32:30 +0800 Larry Chen wrote: > ocfs2_inode_lock_tracker as a variant of ocfs2_inode_lock, > is used to prevent deadlock due to recursive lock acquisition. > > But this function does not distinguish > whether the requested level is EX or PR. > > If a RP lock has been atta

Re: [Ocfs2-devel] [PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level

2018-05-10 Thread Gang He
Hello Joseph, Changwei and Jun/Alex, Please help to take a look at this patch, since the previous patch really has vulnerability in logic, although our test cases did not hit it. Thanks Gang >>> Larry Chen 2018/5/10 13:32 >>> ocfs2_inode_lock_tracker as a variant of ocfs2_inode_lock, is us

[PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level

2018-05-09 Thread Larry Chen
ocfs2_inode_lock_tracker as a variant of ocfs2_inode_lock, is used to prevent deadlock due to recursive lock acquisition. But this function does not distinguish whether the requested level is EX or PR. If a RP lock has been attained, this function will immediately return success afterwards even a