Re: [PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-16 Thread Robin Murphy
On 15/09/16 14:36, Rob Herring wrote: > On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: >> Whilst we're some of the way towards a universal firmware property >> interface, drivers which deal with both OF and ACPI probing end up >> having to do things like this: >> >> dev->of_node

Re: [PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-16 Thread Robin Murphy
On 15/09/16 14:36, Rob Herring wrote: > On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: >> Whilst we're some of the way towards a universal firmware property >> interface, drivers which deal with both OF and ACPI probing end up >> having to do things like this: >> >> dev->of_node

Re: [PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-16 Thread Lorenzo Pieralisi
On Thu, Sep 15, 2016 at 08:36:57AM -0500, Rob Herring wrote: > On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: > > Whilst we're some of the way towards a universal firmware property > > interface, drivers which deal with both OF and ACPI probing end up > > having to do things like

Re: [PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-16 Thread Lorenzo Pieralisi
On Thu, Sep 15, 2016 at 08:36:57AM -0500, Rob Herring wrote: > On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: > > Whilst we're some of the way towards a universal firmware property > > interface, drivers which deal with both OF and ACPI probing end up > > having to do things like

Re: [PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-15 Thread Rob Herring
On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: > Whilst we're some of the way towards a universal firmware property > interface, drivers which deal with both OF and ACPI probing end up > having to do things like this: > > dev->of_node ? >of_node->fwnode : dev->fwnode > > This

Re: [PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-15 Thread Rob Herring
On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: > Whilst we're some of the way towards a universal firmware property > interface, drivers which deal with both OF and ACPI probing end up > having to do things like this: > > dev->of_node ? >of_node->fwnode : dev->fwnode > > This

[PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-14 Thread Robin Murphy
Whilst we're some of the way towards a universal firmware property interface, drivers which deal with both OF and ACPI probing end up having to do things like this: dev->of_node ? >of_node->fwnode : dev->fwnode This seems unnecessary, when the OF code could instead simply fill in the

[PATCH] of/platform: Initialise dev->fwnode appropriately

2016-09-14 Thread Robin Murphy
Whilst we're some of the way towards a universal firmware property interface, drivers which deal with both OF and ACPI probing end up having to do things like this: dev->of_node ? >of_node->fwnode : dev->fwnode This seems unnecessary, when the OF code could instead simply fill in the