Re: [PATCH] of: Fix NULL dereference in selftest removal code

2014-10-05 Thread Gaurav Minocha
Thanks for the fix, I just noted that you increased NO_OF_NODES to 3 in following phandle resolver patch. So, with NO_OF_NODES = 3, the following patch works fine on arm, x86 and powerpc. On Wed, Oct 1, 2014 at 9:02 AM, Grant Likely wrote: > The selftest code removes its testcase data from the

Re: [PATCH] of: Fix NULL dereference in selftest removal code

2014-10-05 Thread Gaurav Minocha
Thanks for the fix, I just noted that you increased NO_OF_NODES to 3 in following phandle resolver patch. So, with NO_OF_NODES = 3, the following patch works fine on arm, x86 and powerpc. On Wed, Oct 1, 2014 at 9:02 AM, Grant Likely grant.lik...@linaro.org wrote: The selftest code removes its

[PATCH] of: Fix NULL dereference in selftest removal code

2014-10-01 Thread Grant Likely
The selftest code removes its testcase data from the live tree when exiting, but if the testcases data tree contains an empty child of the root, then it causes an oops due to a NULL dereference. The reason is that the code tries to directly dereference the child pointer without checking first if a

[PATCH] of: Fix NULL dereference in selftest removal code

2014-10-01 Thread Grant Likely
The selftest code removes its testcase data from the live tree when exiting, but if the testcases data tree contains an empty child of the root, then it causes an oops due to a NULL dereference. The reason is that the code tries to directly dereference the child pointer without checking first if a