Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-13 Thread Rob Herring
On Wed, Mar 4, 2015 at 1:49 PM, Arnd Bergmann wrote: > On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: >> > - depends on OF_IRQ && OF_EARLY_FLATTREE >> > + depends on OF_IRQ && OF_EARLY_FLATTREE && I2C=y && I2C_MUX=y >> >> ... I think it would be better to replace "#if

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-13 Thread Rob Herring
On Wed, Mar 4, 2015 at 1:49 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: - depends on OF_IRQ OF_EARLY_FLATTREE + depends on OF_IRQ OF_EARLY_FLATTREE I2C=y I2C_MUX=y ... I think it would be better to replace #if

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-09 Thread Arnd Bergmann
On Thursday 05 March 2015 09:06:54 Geert Uytterhoeven wrote: > On Wed, Mar 4, 2015 at 8:49 PM, Arnd Bergmann wrote: > > --- a/drivers/of/unittest.c > > +++ b/drivers/of/unittest.c > > @@ -979,7 +979,7 @@ static int of_path_platform_device_exists(const char > > *path) > > return pdev !=

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-09 Thread Arnd Bergmann
On Thursday 05 March 2015 09:06:54 Geert Uytterhoeven wrote: On Wed, Mar 4, 2015 at 8:49 PM, Arnd Bergmann a...@arndb.de wrote: --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -979,7 +979,7 @@ static int of_path_platform_device_exists(const char *path) return pdev !=

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-05 Thread Rob Herring
On Wed, Mar 4, 2015 at 1:58 PM, Pantelis Antoniou wrote: > Hi Arnd, > >> On Mar 4, 2015, at 21:49 , Arnd Bergmann wrote: >> >> On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: - depends on OF_IRQ && OF_EARLY_FLATTREE + depends on OF_IRQ && OF_EARLY_FLATTREE &&

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-05 Thread Chen Gang
On 3/5/15 16:06, Geert Uytterhoeven wrote: > On Wed, Mar 4, 2015 at 8:49 PM, Arnd Bergmann wrote: >> --- a/drivers/of/unittest.c >> +++ b/drivers/of/unittest.c >> @@ -979,7 +979,7 @@ static int of_path_platform_device_exists(const char >> *path) >> return pdev != NULL; >> } >> >> -#if

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-05 Thread Geert Uytterhoeven
On Wed, Mar 4, 2015 at 8:49 PM, Arnd Bergmann wrote: > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -979,7 +979,7 @@ static int of_path_platform_device_exists(const char > *path) > return pdev != NULL; > } > > -#if IS_ENABLED(CONFIG_I2C) > +#if IS_BUILTIN(CONFIG_I2C)

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-05 Thread Chen Gang
On 3/5/15 16:06, Geert Uytterhoeven wrote: On Wed, Mar 4, 2015 at 8:49 PM, Arnd Bergmann a...@arndb.de wrote: --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -979,7 +979,7 @@ static int of_path_platform_device_exists(const char *path) return pdev != NULL; } -#if

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-05 Thread Rob Herring
On Wed, Mar 4, 2015 at 1:58 PM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Arnd, On Mar 4, 2015, at 21:49 , Arnd Bergmann a...@arndb.de wrote: On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: - depends on OF_IRQ OF_EARLY_FLATTREE + depends on OF_IRQ

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-05 Thread Geert Uytterhoeven
On Wed, Mar 4, 2015 at 8:49 PM, Arnd Bergmann a...@arndb.de wrote: --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -979,7 +979,7 @@ static int of_path_platform_device_exists(const char *path) return pdev != NULL; } -#if IS_ENABLED(CONFIG_I2C) +#if

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-04 Thread Pantelis Antoniou
Hi Arnd, > On Mar 4, 2015, at 21:49 , Arnd Bergmann wrote: > > On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: >>> - depends on OF_IRQ && OF_EARLY_FLATTREE >>> + depends on OF_IRQ && OF_EARLY_FLATTREE && I2C=y && I2C_MUX=y >> >> ... I think it would be better to

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-04 Thread Arnd Bergmann
On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: > > - depends on OF_IRQ && OF_EARLY_FLATTREE > > + depends on OF_IRQ && OF_EARLY_FLATTREE && I2C=y && I2C_MUX=y > > ... I think it would be better to replace "#if IS_ENABLED(CONFIG_XXX)" by > "#ifdef CONFIG_XXX" in

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-04 Thread Geert Uytterhoeven
On Wed, Mar 4, 2015 at 7:37 AM, Chen Gang wrote: > They need several symbols which are in I2C and I2C_MUX, the related > error: > > drivers/built-in.o: In function `selftest_i2c_mux_remove': > unittest.c:(.text+0xb0ce4): undefined reference to `i2c_del_mux_adapter' >

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-04 Thread Arnd Bergmann
On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: - depends on OF_IRQ OF_EARLY_FLATTREE + depends on OF_IRQ OF_EARLY_FLATTREE I2C=y I2C_MUX=y ... I think it would be better to replace #if IS_ENABLED(CONFIG_XXX) by #ifdef CONFIG_XXX in drivers/of/unittest.c

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-04 Thread Pantelis Antoniou
Hi Arnd, On Mar 4, 2015, at 21:49 , Arnd Bergmann a...@arndb.de wrote: On Wednesday 04 March 2015 16:04:23 Geert Uytterhoeven wrote: - depends on OF_IRQ OF_EARLY_FLATTREE + depends on OF_IRQ OF_EARLY_FLATTREE I2C=y I2C_MUX=y ... I think it would be better to replace #if

Re: [PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-04 Thread Geert Uytterhoeven
On Wed, Mar 4, 2015 at 7:37 AM, Chen Gang xili_gchen_5...@hotmail.com wrote: They need several symbols which are in I2C and I2C_MUX, the related error: drivers/built-in.o: In function `selftest_i2c_mux_remove': unittest.c:(.text+0xb0ce4): undefined reference to `i2c_del_mux_adapter'

[PATCH] of: Kconfig: Let OF_UNITTEST depend on "I2C=y" and "I2C_MUX=y"

2015-03-03 Thread Chen Gang
They need several symbols which are in I2C and I2C_MUX, the related error: drivers/built-in.o: In function `selftest_i2c_mux_remove': unittest.c:(.text+0xb0ce4): undefined reference to `i2c_del_mux_adapter' unittest.c:(.text+0xb0ce8): undefined reference to `i2c_del_mux_adapter'

[PATCH] of: Kconfig: Let OF_UNITTEST depend on I2C=y and I2C_MUX=y

2015-03-03 Thread Chen Gang
They need several symbols which are in I2C and I2C_MUX, the related error: drivers/built-in.o: In function `selftest_i2c_mux_remove': unittest.c:(.text+0xb0ce4): undefined reference to `i2c_del_mux_adapter' unittest.c:(.text+0xb0ce8): undefined reference to `i2c_del_mux_adapter'